Skip to content

[geo-tools] GoogleAddressProvider now handles more API variants for location requests #1719

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
johannes-goltz wants to merge 2 commits into
base: master
Choose a base branch
from
Open

[geo-tools] GoogleAddressProvider now handles more API variants for location requests #1719

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8688fbd
GoogleAddressProvider now handles more API variants for location requ…
johannes-goltz Jun 15, 2026
b7a8e75
Comments on api responses added
johannes-goltz Jun 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions change/@itwin-geo-tools-react-6582ffe5-6858-4b66-9546-d92b561112ee.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "patch",
"comment": "GoogleAddressProvider does not always resolve location requests correctly. Now handling different API variants",
"packageName": "@itwin/geo-tools-react",
"email": "Johannes.Goltz@bentley.com",
"dependentChangeType": "patch"
}
15 changes: 13 additions & 2 deletions packages/itwin/geo-tools/src/GoogleAddressProvider.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,8 +73,19 @@ export class GoogleAddressProvider implements AddressProvider {
} });
const json: any = await response.json();

const lat = json?.location?.geometry?.latitude
const long = json?.location?.geometry?.longitude
// Google Address Validation API response shape: { location: { latitude, longitude } }
// @see https://developers.google.com/maps/documentation/address-validation/reference/rest/v1/TopLevel/validateAddress#Location
const lat = json?.location?.latitude
// Google Geocoding API response shape: { result: { geometry: { location: { lat, lng } } } }
// @see https://developers.google.com/maps/documentation/geocoding/requests-geocoding#Results
?? json?.result?.geometry?.location?.lat
// Legacy/wrapper format: { location: { geometry: { latitude, longitude } } }
?? json?.location?.geometry?.latitude;

const long = json?.location?.longitude
?? json?.result?.geometry?.location?.lng
?? json?.location?.geometry?.longitude;

if (lat === undefined || long === undefined) {
throw new Error("Invalid location data");
}
Expand Down
Loading