Skip to content

Turning off all properties on Advanced Filtering dialog hides elements incorrectly #238

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
naronchen merged 3 commits into from
Jul 7, 2025
Merged

Turning off all properties on Advanced Filtering dialog hides elements incorrectly #238

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4accba3
fix
naronchen Jun 23, 2025
9e12707
changeset
naronchen Jun 23, 2025
eb26a2d
Merge branch 'master' into naron/advFilter-with-other-typeofchange-ch…
naronchen Jul 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/tender-camels-report.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@itwin/changed-elements-react": patch
---

bug fix- Turning off all properties on Advanced Filtering dialog hides elements incorrectly
5 changes: 5 additions & 0 deletions packages/changed-elements-react/src/widgets/EnhancedElementsInspector.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1011,6 +1011,11 @@ export class ChangedElementsListComponent extends Component<ChangedElementsListP
return true;
}

// keep the entry if user has typeOfChange filtering other than properties checked and matches
if (((entry.type & ~TypeOfChange.Property) & (options.wantedTypeOfChange)) !== 0) {
return true;
}

// Only thing left to do is to check that the entry's properties are visible in filters
return this._anyEntryPropertiesVisible(entry, options);
};
Expand Down
Loading