Skip to content

changedElementsHeaderButtons spacing#235

Merged
naronchen merged 2 commits into
masterfrom
naron/changed-elems-buttons-spacing
Jun 18, 2025
Merged

changedElementsHeaderButtons spacing#235
naronchen merged 2 commits into
masterfrom
naron/changed-elems-buttons-spacing

Conversation

@naronchen

Copy link
Copy Markdown
Contributor

JP mentioned this when i worked on the bug on right aligning header button that he want a bit more spacing between those buttons.

the side effect of this change is when squeezing it becomes
image
cuz of the fixed spacing

while previously if squeezed:
image

@naronchen naronchen requested a review from a team as a code owner June 13, 2025 17:55
@naronchen naronchen requested a review from mattbjordan June 13, 2025 17:55
@changeset-bot

changeset-bot Bot commented Jun 13, 2025

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 65c3347

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@itwin/changed-elements-react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

diegopinate
diegopinate previously approved these changes Jun 17, 2025
@naronchen naronchen merged commit ded75e2 into master Jun 18, 2025
4 checks passed
@naronchen naronchen deleted the naron/changed-elems-buttons-spacing branch June 18, 2025 10:55
naronchen added a commit that referenced this pull request Jun 23, 2025
JP mentioned this when i worked on the bug on right aligning header
button that he want a bit more spacing between those buttons.

the side effect of this change is when squeezing it becomes

![image](https://github.com/user-attachments/assets/bb71944c-6732-42ca-b82c-89795bcc68f5)
cuz of the fixed spacing


while previously if squeezed:

![image](https://github.com/user-attachments/assets/3344c4de-df5e-4670-a17c-9430a4c3cf03)

---------

Co-authored-by: naronchen <naronchen@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants