Skip to content

Naron/nv table loading#234

Merged
naronchen merged 16 commits into
masterfrom
naron/NV-table-loading
Jun 26, 2025
Merged

Naron/nv table loading#234
naronchen merged 16 commits into
masterfrom
naron/NV-table-loading

Conversation

@naronchen

@naronchen naronchen commented Jun 12, 2025

Copy link
Copy Markdown
Contributor
  • refactored NamedVersionSelector: merged namedVersionCompareSelector with the changedElement widget components into one in their parent component, extracted the NV table so that it stays throughout the phase changes.

  • applied useContext for NamedVersionSelector content related props to flatten the structure

@naronchen naronchen requested a review from a team as a code owner June 12, 2025 21:51
@naronchen naronchen requested a review from diegopinate June 12, 2025 21:51
@changeset-bot

changeset-bot Bot commented Jun 12, 2025

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 660ba79

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@itwin/changed-elements-react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Comment thread packages/changed-elements-react/src/NamedVersionSelector/NamedVersionSelector.tsx Outdated
Comment thread packages/changed-elements-react/src/NamedVersionSelector/NamedVersionSelector.tsx Outdated
Comment thread packages/changed-elements-react/src/NamedVersionSelector/NamedVersionSelector.tsx Outdated
Comment thread packages/changed-elements-react/src/api/VersionCompareManager.ts
naronchen and others added 5 commits June 23, 2025 13:33
This PR was opened by the [Changesets
release](https://github.com/changesets/action) GitHub action. When
you're ready to do a release, you can merge this and the packages will
be published to npm automatically. If you're not ready to do a release
yet, that's fine, whenever you add more changesets to master, this PR
will be updated.

# Releases
## @itwin/changed-elements-react@0.15.4

### Patch Changes

####
[0.15.4](https://github.com/iTwin/changed-elements-react/tree/v0.15.4/packages/changed-elements-react)
- 2025-06-06

fix alignment in header of version comapre

Co-authored-by: imodeljs-admin <imodeljs-admin@users.noreply.github.com>
JP mentioned this when i worked on the bug on right aligning header
button that he want a bit more spacing between those buttons.

the side effect of this change is when squeezing it becomes

![image](https://github.com/user-attachments/assets/bb71944c-6732-42ca-b82c-89795bcc68f5)
cuz of the fixed spacing


while previously if squeezed:

![image](https://github.com/user-attachments/assets/3344c4de-df5e-4670-a17c-9430a4c3cf03)

---------

Co-authored-by: naronchen <naronchen@users.noreply.github.com>
@naronchen naronchen merged commit a4c84d5 into master Jun 26, 2025
4 checks passed
@naronchen naronchen deleted the naron/NV-table-loading branch June 26, 2025 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants