Skip to content

Naron/search pill missing returning from version compare frontstage #225

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
naronchen merged 2 commits into from
May 15, 2025
Merged

Naron/search pill missing returning from version compare frontstage #225

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
40e1cdc
fix, preserve searched text
naronchen May 15, 2025
e6ba35f
changeset
naronchen May 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/upset-lizards-reply.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@itwin/changed-elements-react": patch
---

bug on filter pill missing after switching page
6 changes: 5 additions & 1 deletion packages/changed-elements-react/src/common/ExpandableSearchBar/ExpandableSearchBar.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,9 @@ export interface ExpandableSearchBarProps {

/** On search text change handler. */
onChange?: (searchText: string) => void;

/** searched text preserved when switching to front stage */
searchedText?: string;
}

/**
Expand All @@ -62,9 +65,10 @@ export function ExpandableSearchBar({
valueChangedDelay,
onChange,
setFocus = false,
searchedText = "",
}: ExpandableSearchBarProps): ReactElement {
const [expanded, setExpanded] = useState(false);
const [searchText, setSearchText] = useState<string>();
const [searchText, setSearchText] = useState<string>(searchedText);
const [timeoutId, setTimeoutId] = useState(0);
const inputElement = useRef<HTMLInputElement>(null);

Expand Down
3 changes: 3 additions & 0 deletions packages/changed-elements-react/src/widgets/EnhancedElementsInspector.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -195,6 +195,7 @@ interface FilterHeaderProps {
wantPropertyFiltering?: boolean;
iModelConnection: IModelConnection | undefined;
onSearchChanged?: (newFilter: string) => void;
searchedText: string | undefined;
}

function ChangeTypeFilterHeader(props: FilterHeaderProps): ReactElement {
Expand Down Expand Up @@ -407,6 +408,7 @@ function ChangeTypeFilterHeader(props: FilterHeaderProps): ReactElement {
setFocus={true}
valueChangedDelay={500}
onChange={props.onSearchChanged}
searchedText={props.searchedText}
>
<IconButton
size="small"
Expand Down Expand Up @@ -1411,6 +1413,7 @@ export class ChangedElementsListComponent extends Component<ChangedElementsListP
onShowAll={this.onHandleShowAll}
onHideAll={this.onHandleHideAll}
onInvert={this.onInvert}
searchedText={this.state.search}
/>
<ChangedElementsBreadCrumb
rootLabel={IModelApp.localization.getLocalizedString(
Expand Down
Loading