Naron/overall loading

[naronchen]

#201

[changeset-bot]

🦋 Changeset detected

Latest commit: 79f15aa

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
@itwin/changed-elements-react	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[naronchen]

Overview:

In NameVersionSelectWidget there's a isComparing flag that returns NamedVersionSelector at first. When user click to view a comparison, the startComparisonV2 gets triggered, running async, it triggers this.versionCompareStarting.raiseEvent() at the beginning, which flipped the flag.

the flag flip will render ChangedElementWidget, there the listeners for loading messages gets hooked in. but we have some events already getting triggered in startComparisonV2 which has gone to void.

The result of this:

from my testing, listener gets hooked in on CheckpointConnection.openRemote, so if downloading the imodel takes a long time, the loading message will stay as 0%.

Diego mentioned its fine that listener hooked in later. But i thought its still worth documenting this and putting the problem out :)