Enable local API support for Rexel#2128
Merged
Merged
Conversation
Rexel gateways support the local API and the paste-a-token UX, so add Server.REXEL to SERVERS_WITH_LOCAL_API. This lets consumers (e.g. the Home Assistant overkiz integration) offer the local-or-cloud choice for Rexel.
Add a 'Rexel (local)' tab to the getting-started guide with the EConnect app token-generation steps and supported gateways, and note Rexel under Local Token auth in core concepts.
Set name/manufacturer for the Rexel local example and note that the default server value must be kept for local token auth routing.
Move the APIType.LOCAL check to the top of build_auth_strategy so a local config can carry any server identity (e.g. Server.REXEL) for labelling without misrouting to that server's cloud strategy. No built-in server uses APIType.LOCAL, so this cannot steal cloud routing. Add a regression test and update the Rexel local docs to set server=Server.REXEL.
Revert the factory reorder and its regression test from this branch (now tracked in the dedicated PR), and drop the server=Server.REXEL example and accompanying note that depended on that fix. The Rexel local example keeps name/manufacturer labelling, which works against released code.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Server.REXELtoSERVERS_WITH_LOCAL_APIinpyoverkiz/const.py.Rexel Energeasy Connect gateways support the local API and the paste-a-token UX, so they should be eligible for the local-or-cloud choice that consumers gate on this list.
Docs
48, V257, V3120, V3 Rail Din125).name/manufacturerfor Rexel labeling but keeps the defaultservervalue, since local token auth is only selected whenserveris not a cloud-mapped server likeServer.REXEL.Notes
SERVERS_WITH_LOCAL_API, so nothing to update there.