Repository navigation
Phase 2: admin screens on IPF - #3
Merged
Merged
Conversation
Categories, forums (with moderators and group permissions), permission template, reports, suspensions, digests, archive, prune and recount. Every operation that writes requires POST and a valid security token, including deletion confirmations. Works around three core issues found on a real installation: the admin menu missing after a menu cache rebuild, count(null) on an empty permission select, and the date picker needing the theme before the form is built. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01MZy45V5RV9nx6Buq8vqKHr
icms_module_Object sets hasconfig for any 'config' array, even an empty one. The admin menu then offered a Preferences link for imforum, and the preferences page, finding no settings, sent the user on to the system module's preferences. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01MZy45V5RV9nx6Buq8vqKHr
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
All admin screens for imforum, built on
icms_ipf_view_TableandgetSecureForm():Security
imforum_admin_op()runs every write operation only on POST with a valid token. A deletion confirmation (confirm=1) needs a valid token too, becauseicms_ipf_Controllerdoes not check it.Core issues worked around
These were found by installing ImpressCMS 2.0.4 through the web installer, installing imforum and clicking through every screen:
include_onces menu.php into another module object, sodisplayAdminMenu()fails oncount(null).imforum_admin_menu()loads the menu itself.saveItem_Permissions()fails oncount(null).imforum_admin_store()turns missing fields into empty arrays first.$xoTheme, so forms are passed as closures and rendered aftericms_cp_header().Tests
AdminRequestTest), and each menu entry pointing to an existing script with the right tab index.AdminToolsTest): moderators via the forum form, hidden counters that get recounted,synchroniseAll,findInactiveandmoveToForum.Generated by Claude Code