Repository navigation
Repair script: skip deleted issues and shared new names - #524
Merged
Merged
Conversation
The dry run on dev stopped at ifixit#34336: GitHub answers 410 for a deleted issue, not 404, so the guard let it through and the script crashed. It also mapped both FoF and squad-carpenter to carpenter in ifixit: their PRs carry both old labels, so carpenter is new on every one of them for either label. Two old labels with one new name are now listed and left alone. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖
The repair script's dry run on dev, with #523's fix, crashed partway through, and it got one guess wrong before that. Nothing was written: it only lists.
410 This issue was deletedfor ifixit#34336, not 404, so the deleted-issue guard didn't catch it. It now skips both.FoF -> carpenterandsquad-carpenter -> carpenter. Those PRs carry both old labels, socarpenterlooks new on every one of them for either label, and only one can be the rename. When two old labels point at one new name in a repo, both are now listed and left alone.Renames the dry run proposed in ifixit before the crash
Every other stale ifixit label (about 75, mostly years-old labels that were deleted) had no single new name and is left alone.
QA
bin/repair-renamed-labelswith no flag. It runs to the end and listsFoFandsquad-carpenteras sharing a new name.🤖 Generated with Claude Code