Repository navigation
Add on-demand storage fakes and fix root signed URLs - #619
Merged
Merged
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Laravel Updates
Storage::fake('ondemand')andStorage::persistentFake('ondemand')to replace anonymousStorage::build()calls. Builds with an explicit logical name retain their own configuration. Forgetting or purging the fake restores normal construction.Additional Hypervel Fixes
/, but validation constructed//and rejected the generated signature. Extend the existing relative-signature test to cover the root route and invalid signatures.ondemandas a configured disk name so a real cached disk cannot replace unrelated anonymous builds. Reject the configuration with a rename instruction, document the difference from Laravel, and preserve explicit logical names and pool identities.Summary by CodeRabbit
ondemanddisk name and can be reused for matching anonymous disk builds. Explicitly named builds retain their own configuration.ondemandis reserved and that configured disks cannot use this name.