docs: add Signed commits section to CONTRIBUTING - #93
Conversation
Owner ruling D218. See docs/SIGNING-POLICY.adoc in hyperpolymath/standards. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01WRvDivYwLSeVCJUrfjic3f
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (2)
Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review. 📜 Recent review details⏰ Context from checks skipped due to timeout. (14)
|
| Layer / File(s) | Summary |
|---|---|
Signed-commit requirements CONTRIBUTING.adoc, docs/CONTRIBUTING.adoc |
Both guides specify SSH signing with a GitHub-registered key and verified committer email for people and interactive agents. They direct apps, bots and workflows to use API-based commits. They also describe squash-only merges and unsigned PR-branch commits blocking merges. |
Priority: ⬇️ Low
Estimated code review effort: 1 (Trivial) | ~3 minutes
Change: Other
Merge Risk: ⚪ Minimal · up to 581f3
The guides consistently describe signed commits and squash merging, and the signature requirement is confirmed. No concrete merge-blocking issue is established; the rebase-merge setting could not be independently verified.
Security Architecture Review
Security architecture risk: ⚪ Minimal · up to 581f3
The change documents separate signing paths for people and automation without granting additional permissions or weakening controls. No material security risk was found in the added guidance. Actual enforcement settings remain separate from this documentation change.
Retained concerns
No architecture-level concerns identified.
Security review details
Security Blast Radius
- inferred — The direct security-relevant scope is contributor guidance for admitting changes to this repository's default branch. The supplied changed surface does not expand runtime, tenant, credential, or deployment authority.
Trust Boundaries and Controls
- inferred — The guidance preserves separate human and automation signing paths and instructs contributors to satisfy signature checks rather than bypass them. Its enforcement assertions are documentation, not independently sufficient evidence of effective hosting-provider controls.
Resilience and Maintainability Implications
- observed — For an unsigned PR branch, both guides prescribe recreating signed commits and opening a new PR. This is manual recovery guidance, not a new automated state transition or rollback mechanism.
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
| Check name | Status | Explanation |
|---|---|---|
| Title check | ✅ Passed | The title clearly identifies the documentation change and names the added Signed commits section in CONTRIBUTING. |
| Description check | ✅ Passed | The description directly explains the signed-commit guidance, affected contributor types, merge requirements, policy reference, and documentation-only scope. |
| Docstring Coverage | ✅ Passed | No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0… |
| Linked Issues check | ✅ Passed | Check skipped because no linked issues were found for this pull request. |
| Out of Scope Changes check | ✅ Passed | Check skipped because no linked issues were found for this pull request. |
✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
- Commit to this branch
- Create a new PR
- Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Autopilot is currently an internal CodeRabbit preview.
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
A rabbit signs each commit with care,
A verified email travels there.
Bots use the API to write,
Squash merges keep the branch in sight.
No unsigned commits hop through the gate.
Comment @coderabbitai help to get the list of available commands.
Adds a Signed commits section to this repo's CONTRIBUTING, per owner ruling D218. The estate policy is
docs/SIGNING-POLICY.adocin hyperpolymath/standards.This repo's default branch is covered by the zero-bypass
Require-Signed-Commitsruleset, and rebase-merge is off. The section tells contributors what that requires:If the file already had its own signing section, that section is replaced in place instead of adding a second one. Lines elsewhere that told people to sign with GPG are changed to match the policy (SSH for people).
This is a docs-only change. The commit was created through
createCommitOnBranch, so GitHub signs it.🤖 Generated with Claude Code
https://claude.ai/code/session_01WRvDivYwLSeVCJUrfjic3f