docs: correct 8 prose sites claiming src/abi/ holds the Idris2 modules - #839
Merged
Merged
Conversation
PR #835 fixed every reference naming a specific `src/abi/*.idr` FILE, but a `.idr`-filename regex cannot see the other half of the same defect: prose that names the DIRECTORY and asserts it contains the Idris2 ABI. Those claims are equally false and were left standing. `src/abi/` holds exactly three files -- `README.adoc`, `hypatia-abi.ipkg` and `hypatia-abi-gen.ipkg`. The modules live in `src/Hypatia/ABI/`; the ipkg sets `sourcedir = ".."`, which is why the build line still names `src/abi/`. Corrected (8 sites, all verified in context before editing): docs/EXPLAINME.adoc:76,119 docs/operations/prover-wars-integration.adoc:39 docs/proofs/gap-analysis.adoc:79 docs/quickstart/llm-warmup-dev.adoc:117 docs/quickstart/llm-warmup-user.adoc:47 docs/quickstart/user.adoc:43 docs/wiki-pages/Architecture.md:102 Two stated module counts were also wrong and are fixed with them: the dev warmup said "5 modules" and EXPLAINME/Architecture listed five, against seven live modules (RuleEngine.idr and Gen.idr were both missing). Also corrects an overclaim this PR's predecessor introduced. The NOTE in `verification/PROOF-STATUS.adoc` said "every one of the twenty" LOC figures had gone wrong. Sixteen were wrong; four tilde-approximations (PageRankInvariants 120/~120, ESNSpectralScaling 144/~145, BayesianUpdate 188/~190, ParserTotality 191/~190) landed within two lines. A false count inside a note about false counts is not acceptable, whichever direction it errs in. Deliberately NOT changed, each verified correct as written: - `verify-proofs.yml` paths filters, Justfile, stapeln.toml, the ipkg build lines -- `src/abi/` is genuinely where the packages live - DEBT-REGISTER.adoc, HANDOVER-neural-convergence.adoc and unified-api-adapter-contract_test.exs -- past-tense records of the deleted duplicates, correct precisely because they name the old path - lib/rules/structural_drift.ex:1130 -- quotes gitbot-fleet's INTENT file as measured evidence for an SD022 defect, not a claim about this repo - .claude/CLAUDE.md's "the two .ipkg files" -- accurate; there are two in `src/abi/`, the third Idris2 package is `verify/hypatia-verify.ipkg` Acceptance: `git grep -n 'src/abi/' -- . ':!data/' | grep -iE 'idris|proof|\.idr|module'` returns 20 hits, every one an ipkg reference, past-tense history, or the `src/abi/README.adoc` title. No false claim survives. All edited AsciiDoc re-rendered clean with `asciidoctor --failure-level=WARN`. Refs #816 Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0113HQM9LVGkNCzU1WwkJZSV
Contributor
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (8)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The half of the defect a filename regex cannot see
PR #835 corrected every reference naming a specific
src/abi/*.idrfile —8 hits, driven down to 1 (past-tense history). But a
.idr-filename regex isblind to the other half of the same defect: prose that names the directory and
asserts it contains the Idris2 ABI. Those claims are just as false, and #835
left all eight standing.
src/abi/holds exactly three files:The modules live in
src/Hypatia/ABI/. The ipkg setssourcedir = "..", whichis why build lines legitimately still name
src/abi/— and why a naivesearch-and-replace across the path would have broken the build documentation.
Corrected — 8 sites, each read in context first
docs/EXPLAINME.adoc:76— formal specs for GraphQL, gRPC, REST with dependent type proofsdocs/EXPLAINME.adoc:119`src/abi/` | Idris2 specs (Types, GraphQL, gRPC, REST, FFI)docs/operations/prover-wars-integration.adoc:39Idris2 ABI definitions insrc/abi/already exportdocs/proofs/gap-analysis.adoc:79+src/abi/+`, `+verify/src/+docs/quickstart/llm-warmup-dev.adoc:117==== Idris2 ABI (src/abi/)docs/quickstart/llm-warmup-user.adoc:47`+src/abi/+` | Idris2 ABI definitionsdocs/quickstart/user.adoc:43Idris2 >= 0.7.0 (for ABI definitions insrc/abi/)docs/wiki-pages/Architecture.md:102**Idris2 ABI** (src/abi/) —Types.idr,GraphQL.idr, …Two stated counts were wrong in the same sentences and are fixed with them.
The dev warmup said "5 modules" and EXPLAINME/Architecture enumerated five;
there are seven live modules —
RuleEngine.idrandGen.idr(added by#120) were missing from every list.
Correcting an overclaim #835 introduced
The
NOTE#835 added toverification/PROOF-STATUS.adocread "every one of thetwenty previously recorded here had gone wrong." That is itself false.
Sixteen were wrong; four tilde-approximations landed within two lines:
PageRankInvariantsESNSpectralScalingBayesianUpdateParserTotalityThe conclusion is unchanged — 16/20 wrong, several by more than double, and
nothing consumed the column — but a false count inside a note about false counts
is not acceptable in either direction. The NOTE now says sixteen and states what
the other four were.
Deliberately NOT changed — each verified correct as written
verify-proofs.ymlpaths filters,Justfile,stapeln.toml, everyidris2 --build src/abi/*.ipkgline —src/abi/is genuinely where thepackages live.
docs/DEBT-REGISTER.adoc,docs/proofs/HANDOVER-neural-convergence.adoc,test/unified-api-adapter-contract_test.exs— past-tense records of thedeleted duplicates. Correct precisely because they name the old path.
lib/rules/structural_drift.ex:1130— quotes gitbot-fleet's INTENT fileas measured evidence for an SD022 defect. Not a claim about this repo.
.claude/CLAUDE.md's "the two.ipkgfiles" — accurate. There are two insrc/abi/; the third Idris2 package isverify/hypatia-verify.ipkg,elsewhere.
Acceptance
→ 20 hits, every one an ipkg/build reference, past-tense history, or the
src/abi/README.adoctitle. No false claim survives.All seven edited AsciiDoc files re-render clean under
asciidoctor --failure-level=WARN.Refs #816.
🤖 Generated with Claude Code
https://claude.ai/code/session_0113HQM9LVGkNCzU1WwkJZSV