fix(validator): recognise colon/brace-block identity + AI.a2ml manifests#41
Merged
Merged
Conversation
The A2ML identity check matched only TOML (`name = ".."`) and s-expr
(`(name "..")`) dialects, so it false-failed three valid dialects with
'Missing required identity field':
- brace-block colon syntax `Trust { name: ".." version: ".." }`
- YAML-ish `id: ".."` / `version: ".."`
- free-text `AI.a2ml` manifests (same doc type as 0-AI-MANIFEST.a2ml)
Adds colon/brace-block identity+version recognition (incl. `id` key) and
whitelists AI.a2ml as a manifest. The identity rule is unchanged for
genuinely identity-less non-manifest files (verified: still errors).
Fixes estate-wide 'Validate A2ML manifests' dogfood-gate false failures.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Repairs estate-wide 'Validate A2ML manifests' false failures. The identity check only matched TOML/s-expr dialects; this adds colon/brace-block (
name:,id:) and whitelistsAI.a2ml. Verified: thunderbird Trust.a2ml, methodologies TSDM.a2ml, asdf AI.a2ml now pass; a genuinely identity-less file still errors (rule intact). Source fix for the dogfood-gate failure class.