Repository navigation
test: scan src/ recursively for Agda citations - #37
Merged
Merged
Conversation
The citation extractor in scripts/check-agda-citations.sh globbed only src/*.jl, and the offline testset only read the immediate entries of src/. A citation in a file under a subdirectory (src/foo/bar.jl) would be missed by both, so the fixture could omit it and both checks still pass (found by the Codex review of #36). Use find and walkdir so every .jl file under src/ is scanned. src/ has no subdirectories today, so the fixture is unchanged: verify passes for the 62 names and Pkg.test() passes (306). Negative control: an unlisted citation in src/nested/control.jl now fails both the script (exit 1) and the testset (1 failure). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0136P7ZnB2Fzqf8br8DGDD4k
Contributor
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 2 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #36, from the Codex review of that PR. The citation extractor in
scripts/check-agda-citations.shglobbed onlysrc/*.jl, and the offline testset read only the top-level entries ofsrc/. A citation in a file under a subdirectory, such assrc/foo/bar.jl, would be missed by both, so the fixture could omit it and both checks would still pass.Changes
scripts/check-agda-citations.sh:find "$ROOT/src" -type f -name '*.jl'in place of thesrc/*.jlglob.test/runtests.jl:walkdir(srcdir)in place ofreaddir(srcdir).Testing
src/has no subdirectories today, so the fixture is unchanged.verifyagainst echo-typesdedda75: 62 names pass.Pkg.test(): 306 pass.src/nested/control.jlnow fails both the script (exit 1,+nested-fake-lemma) and the testset (1 failure). The control file was not committed.Generated by Claude Code