Skip to content

test: scan src/ recursively for Agda citations - #37

Merged
hyperpolymath merged 1 commit into
mainfrom
marina/jolly-volta-lkmb1k
Nov 14, 2026
Merged

hyperpolymath merged 1 commit into
mainfrom
marina/jolly-volta-lkmb1k

Conversation

@hyperpolymath

Copy link
Copy Markdown
Owner

Summary

Follow-up to #36, from the Codex review of that PR. The citation extractor in scripts/check-agda-citations.sh globbed only src/*.jl, and the offline testset read only the top-level entries of src/. A citation in a file under a subdirectory, such as src/foo/bar.jl, would be missed by both, so the fixture could omit it and both checks would still pass.

Changes

  • scripts/check-agda-citations.sh: find "$ROOT/src" -type f -name '*.jl' in place of the src/*.jl glob.
  • test/runtests.jl: walkdir(srcdir) in place of readdir(srcdir).

Testing

  • src/ has no subdirectories today, so the fixture is unchanged. verify against echo-types dedda75: 62 names pass. Pkg.test(): 306 pass.
  • Negative control: an unlisted citation in src/nested/control.jl now fails both the script (exit 1, +nested-fake-lemma) and the testset (1 failure). The control file was not committed.

Generated by Claude Code

The citation extractor in scripts/check-agda-citations.sh globbed only
src/*.jl, and the offline testset only read the immediate entries of
src/. A citation in a file under a subdirectory (src/foo/bar.jl) would
be missed by both, so the fixture could omit it and both checks still
pass (found by the Codex review of #36). Use find and walkdir so every
.jl file under src/ is scanned.

src/ has no subdirectories today, so the fixture is unchanged: verify
passes for the 62 names and Pkg.test() passes (306). Negative control:
an unlisted citation in src/nested/control.jl now fails both the script
(exit 1) and the testset (1 failure).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_0136P7ZnB2Fzqf8br8DGDD4k
@coderabbitai

coderabbitai Bot commented Nov 14, 2026 •

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 2 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: b1c1759d-cccf-4fa0-ae75-4ce8821de5c6
Commits

Reviewing files that changed from the base of the PR and between a665d93 and 9ed61c9.

Files selected for processing: 2

  • scripts/check-agda-citations.sh
  • test/runtests.jl
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@hyperpolymath
hyperpolymath marked this pull request as ready for review November 14, 2026 17:36
@hyperpolymath
hyperpolymath merged commit f6e7d75 into main Nov 14, 2026
6 checks passed
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 14, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-14T17:37:50.340892Z 9ed61c9 Draft marked ready
🔒 Security Review ✅ Completed 2026-11-14T17:39:04.379655Z 9ed61c9 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@hyperpolymath
hyperpolymath deleted the marina/jolly-volta-lkmb1k branch November 14, 2026 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants