Repository navigation
fix(config): read env under DFE_TRANSFORM_VECTOR_ only - #141
Merged
Merged
Conversation
dfe-transform-vector shared the DFE_TRANSFORM prefix with dfe-transform-vrl. It now reads every environment variable under DFE_TRANSFORM_VECTOR_, like the other DFE apps: the scalo cascade, the flat readers, the version-check opt-out and the deployment contract's env_prefix and secret names. The old DFE_TRANSFORM_ names are not read. A flat key that begins VECTOR_ doubles up under the new prefix: DFE_TRANSFORM_VECTOR_BINARY is now DFE_TRANSFORM_VECTOR_VECTOR_BINARY.
|
Released in v1.0.60 -- https://github.com/hyperi-io/dfe-transform-vector/releases/tag/v1.0.60 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
dfe-transform-vector read its settings under
DFE_TRANSFORM_, the prefix dfe-transform-vrl also used. It now reads onlyDFE_TRANSFORM_VECTOR_, like the other DFE apps, for the config cascade, the flat readers, version check and the deployment contract'senv_prefix. The old names are no longer read.Rollout
These set the old names and need to move with this:
appmgmt/apps.yaml, the dfe-transform-vector block (lines 686-708).apps.yamlandhelm/charts/dfe-extras/files/apps.yaml, the same block.argocd/values/apps/dfe-transform-vector/profile-single.yaml,profile-scale.yamlandvalues.yaml.docker-compose.yml, onchore/cleanup.Do not rename by replacing the prefix. Every old
VECTOR_*flat key doubles, sovector.data_diris nowDFE_TRANSFORM_VECTOR_VECTOR_DATA_DIR.DFE_TRANSFORM_VECTOR_DATA_DIRinvalues.yaml:26is the old name, and left as it is, it reads as nothing and the data directory falls back to its default.An older binary ignores the new names and still starts. A new binary given only the old names falls back to
localhost:9092.Testing
hyperi-ci check --quick, fmt and clippy pass. 83 integration tests on config and deployment pass. A binary run reads the new names and ignores the old ones, andonly_the_dfe_transform_vector_prefix_reaches_the_configcovers it. Not run:signals.rs,scaling.rsand the e2e tests, which need a live Vector. Their only change is the env var name.