Repository navigation
fix(vector): restore curl in the runtime image - #139
Merged
Merged
Conversation
The wait-for-engine init container in dfe-common runs in the app's image and polls the engine /readyz with curl. The static-libs change dropped curl from the generated runtime image. The init container loops on "curl: not found", leaving the pod in Init. The Dockerfile is generated from the contract and checked against it. Add curl as an apt package in the contract's native deps and regenerate the Dockerfile. Remove curl installation and purging from the Vector layer. The base layer includes curl, and the purge would remove it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The wait-for-engine init container in dfe-common uses the app's image. It polls the engine /readyz with curl. Without curl, every pod stays at Init.
vector --versionruns.Done when the next release's amd64 and arm64 images both carry curl.