Ignore account blocks that reference the future#4
Open
vilkris4 wants to merge 1 commit into
Open
Conversation
This commit introduces the following change: if an incoming account block references a momentum height that is greater than the node's frontier height, the account block is ignored and not attempted to be validated. It is common for a node to receive such blocks, since peers may be slightly ahead, but when the node fails to validate such a block it will log an error into the node's error log file cluttering the log with unhelpful messages. This change also prevents the node from wasting time trying to validate these blocks.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit introduces the following change: if an incoming account block references a momentum height that is greater than the node's frontier height, the account block is ignored and not attempted to be validated. It is common for a node to receive such blocks, since peers may be slightly ahead, but when the node fails to validate such a block it will log an error into the node's error log file cluttering the log with unhelpful messages.
This change also prevents the node from wasting time trying to validate these blocks.