fix: shell syntax error, port mismatch, stale names, and typos#10
Open
giwaov wants to merge 1 commit into
Open
fix: shell syntax error, port mismatch, stale names, and typos#10giwaov wants to merge 1 commit into
giwaov wants to merge 1 commit into
Conversation
- Fix shell syntax error: remove extra `>` from `source <(hy devnet env)>` - Fix port mismatch: align server default port (9002 -> 9003) to match frontend expectation in .env (VITE_SERVER_BASE_URL=localhost:9003) - Fix wrong package name "blackjack-win95" -> "hyli-app-scaffold" - Fix typo "encsode" -> "encode" and stale "Balances" -> "Contract1 state" - Fix stale error message "hyllar state" -> "Contract1 state" - Fix stale quickstart link with .md extension - Fix generic HTML title "Vite + React + TS" -> "Hyli App Scaffold" - Fix misleading session key comment (said 72h but code sets 24h)
giwaov
force-pushed
the
fix/bugs-typos-misconfigs
branch
from
62d925f to
a6c7b6a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes several bugs and issues that break the out-of-the-box developer experience.
Critical fixes
source <(hy devnet env)>has an extra>that causes a bash error — fixed tosource <(hy devnet env).envexpects server atlocalhost:9003butconf_defaults.tomlstarts server on port9002— aligned to9003so the app works out-of-the-boxfront/package.jsonwas named"blackjack-win95"(leftover from a different project) — renamed to"hyli-app-scaffold"Code fixes
"Failed to encsode Balances"→"Failed to encode Contract1 state"(typo + stale name)"Could not decode hyllar state"→"Could not decode Contract1 state"(stale reference to different contract)Minor fixes
quickstart/run.md→quickstart/(MkDocs sites don't use .md in URLs)"Vite + React + TS"→"Hyli App Scaffold"Test plan
source <(hy devnet env)and verify it works without syntax errorcargo run -p serverand verify it listens on port 9003npm installsucceeds with the new package name