Repository navigation
fix: ignore superseded theme file imports and errors - #7
Merged
Merged
Conversation
hvab
marked this pull request as ready for review
October 19, 2026 13:04
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A delayed JSON file import could overwrite a newer import, confirmed Reset or manual edit, and R05 then persisted the stale theme. A delayed failure could also display an obsolete import error.
Track the latest selected file operation and invalidate it when theme/lock state is replaced or edited, or the component unmounts. Apply success and error only while the operation is current. Clear the file input immediately after capturing the File, so stale cleanup cannot clear a newer selection. UI-only actions and canceled file selection preserve the pending import.
R01 validation and R05 save policy remain unchanged. Extended the existing component harness for stale/current success and errors, both completion orders, semantic actions, unmount, atomic rejection, input/URL ownership and persistence. Independent Sol 6.1 review found no actionable issues; coordinator accepted the diff and repeated 18 temporary reproduction/acceptance cases.
Validation: clean npm ci; focused checks 43/43; full suite 166/166; JavaScript/style lint, formatting, production build and git diff --check pass. Code commit
31b1654passed Node 22/Linux CI; the PR checks report the current head status. Controlled File.text promises establish the ordering behavior; real browser timing and BFCache remain unverified. PROGRESS includes the audit reconciliation, V01 reproduction and correction results. No merge is authorized.