ci: start cache building immediately without waiting for format checks#3
Open
huth-stacks wants to merge 1 commit into
Open
ci: start cache building immediately without waiting for format checks#3huth-stacks wants to merge 1 commit into
huth-stacks wants to merge 1 commit into
Conversation
The create-cache workflow waited for rustfmt, changelog-check, and check-release before starting the 15-minute nextest archive build. These gates are independent from compilation. Test workflows already depend on both create-cache and the format checks independently, so format failures still block test results.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Start the nextest archive build immediately when CI triggers, instead of waiting for rustfmt and changelog checks to pass first.
Why
The
create-cachejob depends onrustfmt,changelog-check, andcheck-release— three trivial jobs (~28 seconds total). This forces the 15-minute nextest archive build to wait for formatting validation, adding 28 seconds to the critical path for no benefit. All test workflows independently depend on bothcreate-cacheAND the format checks, so a format failure still blocks test results.The Change
In
.github/workflows/ci.yml, remove theneedsblock fromcreate-cache:4 lines deleted in 1 file.
How to Verify
create-cacheshould appear at Stage 0 in the workflow graph (parallel with rustfmt)create-cacheandrustfmtbefore runningMetrics to Track
Security Checklist
Part of CI Optimization Series
PR 2 of 7. Expected impact: ~28s off critical path.