ci: skip cargo-hack feature checks on PRs (keep on merge queue)#11
Open
huth-stacks wants to merge 1 commit into
Open
ci: skip cargo-hack feature checks on PRs (keep on merge queue)#11huth-stacks wants to merge 1 commit into
huth-stacks wants to merge 1 commit into
Conversation
Remove pull_request from cargo-hack-check's trigger condition. Feature combination checks still run on merge queue, releases, and manual dispatch — catching issues before they reach develop. PRs skip this 13-minute job for faster feedback.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Skip the cargo-hack feature combination check on PRs. Keep it on merge queue, releases, and manual dispatch.
Why
cargo hack check --all --each-featuretakes 13 minutes per PR, checking every feature combination across all 13 workspace crates for Windows and Linux targets. This is valuable for catching feature flag incompatibilities, but:The Change
In
.github/workflows/ci.yml, removegithub.event_name == 'pull_request'from cargo-hack-check's condition:- github.event_name == 'pull_request' ||1 line removed from 1 file.
After this change, cargo-hack runs on:
Pull requests(skipped for speed)Metrics to Track
Security Checklist
Part of CI Optimization Series
PR 10. Expected impact: ~13 minutes off every PR run.