ci: remove coverage instrumentation from test builds#10
Open
huth-stacks wants to merge 1 commit into
Open
Conversation
Remove -Cinstrument-coverage from RUSTFLAGS in create-cache.yml. This eliminates ~15% compilation overhead, ~56% binary size bloat, and per-test .profraw I/O from every PR run. Coverage data is no longer collected per-PR. The coverage report job will skip gracefully. Standard practice for large Rust projects — coverage on merge, not per-PR. Can be restored by reverting this one-line change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Remove
-Cinstrument-coveragefrom RUSTFLAGS in the test cache build.Why
Coverage instrumentation is applied to ALL test binaries via
create-cache.yml. This adds:Coverage data is only consumed by the
trigger-code-coverage-reportjob. For PR feedback, tests passing/failing matters more than coverage diffs.The Change
In
.github/workflows/create-cache.yml:1 line changed in 1 file.
Metrics to Track
Risk
Security Checklist
Part of CI Optimization Series
PR 9. Expected impact: ~2-3 minutes on archive build + reduced test runner overhead.