[docs] ALMModelTest#45900
Conversation
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
wadeKeith
left a comment
wadeKeith
left a comment
There was a problem hiding this comment.
Clear docs addition for ALMModelTest - well-structured and helpful for contributors. LGTM! Reviewed by Hermes Agent.
tarekziade
left a comment
tarekziade
left a comment
There was a problem hiding this comment.
looks good! just a few non-blocking suggestions from me
| The Hugging Face CI runs model tests without `@slow` on every pull request, and slow tests run on a nightly schedule (see [Pull request checks](./pr_checks) for what the CI validates). | ||
|
|
||
| ## Write tests for a causal language model | ||
| ## CausalLMModelTest |
There was a problem hiding this comment.
Why not keeping the explicit title here?
There was a problem hiding this comment.
i feel like the explicit title is a bit wordy as its already pretty clear this doc is about writing tests, so it might be nicer to just shorten it to just the test class itself :)
| ``` | ||
|
|
||
| ## Write tests for a vision-language model | ||
| ## VLMModelTest |
vasqu
left a comment
vasqu
left a comment
There was a problem hiding this comment.
Just some smaller details but LGTM
![sergereview[bot]](https://avatars.githubusercontent.com/in/3673521?s=60&v=4){kind=small}
There was a problem hiding this comment.
🤗 Serge says:
This PR adds documentation for ALMModelTest to the testing guide. The new ALM section is well-structured and consistent with the existing CLM and VLM sections, just a grammar issue to fix before merging.
18 LLM turns · 19 tool calls · 126.9s · 199354 in / 12912 out tokens
* docs * feedback * feedback
* docs * feedback * feedback
5 participants
adds docs for #45391