refactor: leverage ExecutorTorch's CustomKVCache for per-layer cache management#78
Merged
Merged
Conversation
kimishpatel
commented
Jun 6, 2025
kimishpatel
commented
Collaborator
Collaborator
Author
|
@guangy10 in prep for ring kv cache |
Collaborator
|
Need rebase in order to run in CI |
…management
Summary:
- Replace separate key/value cache tensors with CustomKVCache
instances
- Use CustomKVCache.update() method instead of manual
torch.ops.llama.update_cache calls
- Create self.kv_cache list with one CustomKVCache per layer
- Maintain compatibility with parent StaticCache class
- Fix type safety issues in get_seq_length method
- Simplify cache update logic by leveraging ExecutorTorch's proven
implementation
Test Plan:
CI
Reviewers:
Subscribers:
Tasks:
Tags:
kimishpatel
force-pushed
the
refactor_custom_kv_cache
branch
from
June 10, 2025 03:17
cb5e5bd to
b6d6fe1
Compare
Collaborator
Author
|
@guangy10 rebased |
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
guangy10
self-requested a review
June 10, 2025 18:35
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.