Conversation
|
Thus, I had run rust fmt, so it fixed some whitespaces. |
|
I'm not sure what's going on but looks like all the indentations are gone and there are blank lines between every code line. Can you reformat them first? It's a bit hard to review with the diffs looking like that. |
|
I just run If you don't, well, when I'll recover everything by hand :-) |
|
Just wanna confirm, but how did I'm thinking of just running that once on EDIT: as for how I keep my sources clean, recently I've set it up such that my editor will automatically run |
d4dd567 to
7ebdd98
Compare
|
I created dedicated #359 where I keep how |
Not sure I'm following here. Shouldn't this be |
|
Anyway, I do have a few early remarks (please bear with me, as this is a rather deep-cutting PR):
|
|
@htkhiem I had split this code into two stages to make it easy to review when the fmt PR was revieved. Now I had rebased it and the first commit had gone. Sorry for noise. Meanwhile, I will address your remarks soon. Thanks for review. And no, I don't against json or anything, but init was simpler choise. |
|
Regarding D-Bus: mainly because I can't imagen setup when D-Bus is available and gconf is not. I run it in without any Desktop Environment and my small stumpwm setup works well without D-Bus and because of that I've added file based config in a way which makes releativly happy :-) |
Fixes: #352