Conversation
Still having trouble on startup (needing one refresh), currently looking for that early operation that has to be refactored to wait for the managed server to complete boot up first.
Removed duplicated server start and player set_is_foreground invocations.
This is gonna take a while since there is so much to configure and validate...
Huge diff cuz I accidentally hit `cargo fmt` sorry
Will have to construct these programmatically hence all the boilerplate
Wrong sign bit parsing equaled a DC offset to the whole signal ugh
Contributor
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This implements #339 and will allow Euphonica to become a "music player" in the traditional sense: you install the package/Flathub app, point it to a folder with music, and hit play. All the "MPD stuff" like setting up a config file, starting and stopping the server shall be handled transparently by Euphonica.
In this mode, Euphonica only borrows the MPD executable. It does not hijack control of any existing MPD server running on your system; rather, it spins up its own instance with a socket connection to avoid collisions and an autogenerated config file stored in the config folder of Euphonica, not MPD, again to avoid collisions with existing configs.
Configuration
Now that we're managing our own MPD server, that means the burden of writing the config file is upon us. To this end Euphonica will feature a GUI to configure certain fields that still make sense in a local-player context, e.g. we'll mostly focus on audio outputs and where the library is; things like where the DB files, sticker file, MPD playlist folders should be won't be exposed to the user.
Sneak peek of output config page (multiple outputs can be configured):

Progress:
euphonica-client-git) should some want to keep their system svelte.