Clean up build-type handling, bump CMake min, sync versions to 1.6#151
Open
jeanbez wants to merge 2 commits into
Open
Clean up build-type handling, bump CMake min, sync versions to 1.6#151jeanbez wants to merge 2 commits into
jeanbez wants to merge 2 commits into
Conversation
- CMakeLists.txt: raise cmake_minimum_required 3.10 -> 3.13 (CMP0077 floor; AMReX/OpenPMD self-enforce higher when enabled); project VERSION 1.3.0 -> 1.6.0; replace unconditional set(CMAKE_BUILD_TYPE Debug) with a default-Release gate that honours user-supplied -DCMAKE_BUILD_TYPE and multi-config generators. - docker/ubuntu-24.04-hdf5-2.0.0/Dockerfile: fix mislabelled base image (ubuntu:focal -> ubuntu:24.04) and kitware apt codename (focal -> noble). - CITATION.cff / RELEASE.txt: sync release metadata to v.1.6 (commit + date). - spack/packages/h5bench/package.py: add versions 1.3-1.6; fix "depecrated" typo (now deprecates 1.0-1.2).
Lurgypai
reviewed
May 12, 2026
Collaborator
Lurgypai
left a comment
Lurgypai
left a comment
There was a problem hiding this comment.
The changes look correct.
The new version of pip on ubuntu 24 throws an error when you try to install with pip outside a venv. Add the the flag forces global install
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Initial repository-wide cleanup, no functional change.
CMakeLists.txt:cmake_minimum_required3.10 → 3.13 (actual floor required byCMAKE_POLICY_DEFAULT_CMP0077; AMReX and OpenPMD self-enforce 3.18 / 3.22 when their benchmarks are enabled, so leaving the root at 3.13 keeps baseline builds permissive).CMakeLists.txt: projectVERSION 1.3.0→1.6.0.CMakeLists.txt: remove unconditionalset(CMAKE_BUILD_TYPE Debug); replace with a default-Release gate that honours user-supplied-DCMAKE_BUILD_TYPE=and multi-config generators.docker/ubuntu-24.04-hdf5-2.0.0/Dockerfile: fix mislabelled base image (ubuntu:focal→ubuntu:24.04) and kitware apt codename (focal→noble).CITATION.cff,RELEASE.txt: sync release metadata to v.1.6.spack/packages/h5bench/package.py: add versions 1.3–1.6; fixdepecratedtypo (now correctly deprecates 1.0–1.2).Test plan
cmake -B builddefaults to Release.cmake -B build -DCMAKE_BUILD_TYPE=Debugis honoured.docker build docker/ubuntu-24.04-hdf5-2.0.0succeeds.