Skip to content

Implemented: support to manage multiple app versions(#448)#449

Draft
ymaheshwari1 wants to merge 1 commit into
hotwax:mainfrom
ymaheshwari1:#448
Draft

Implemented: support to manage multiple app versions(#448)#449
ymaheshwari1 wants to merge 1 commit into
hotwax:mainfrom
ymaheshwari1:#448

Conversation

@ymaheshwari1

Copy link
Copy Markdown
Contributor

Unregister all the service workers othen than the current app version Updated app info component to honor the env app version if available

Related Issues

Short Description and Why It's Useful

Screenshots of Visual Changes before/after (If There Are Any)

Is the changes contains any breaking change?

If there are any breaking change include those in the release notes file

  • Yes
  • No

Contribution and Currently Important Rules Acceptance

Unregister all the service workers othen than the current app version
Updated app info component to honor the env app version if available
@gemini-code-assist

Copy link
Copy Markdown

Summary of Changes

Hello @ymaheshwari1, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces improvements for managing different application versions, particularly in environments where multiple versions might coexist or be deployed sequentially. It ensures that service workers from previous or inactive application versions are automatically unregistered, preventing potential conflicts or stale caching issues. Additionally, it refines how the application version is displayed within the DxpAppVersionInfo component, making it more adaptable to various build and deployment configurations.

Highlights

  • Service Worker Management: Implemented logic to unregister outdated service workers, ensuring only the service worker for the currently running application version remains active. This prevents potential conflicts and stale caching issues when multiple app versions are deployed.
  • App Version Display Logic: Enhanced the DxpAppVersionInfo component to prioritize process.env.VUE_APP_BUILD for displaying the application version. If VUE_APP_BUILD is not available, it falls back to appInfo.tag, and then to appInfo.branch + "-" + appInfo.revision, providing more flexibility in version identification.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces support for managing multiple app versions by unregistering old service workers and updating how the app version string is constructed. The changes are a good step forward. I've provided a couple of suggestions to improve code readability in DxpAppVersionInfo.vue and to enhance the robustness of the service worker cleanup logic in service-worker.ts by adding necessary checks and error handling.

Comment thread src/service-worker.ts
Comment thread src/components/DxpAppVersionInfo.vue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant