Implemented: support to manage multiple app versions(#448)#449
Implemented: support to manage multiple app versions(#448)#449ymaheshwari1 wants to merge 1 commit into
Conversation
Unregister all the service workers othen than the current app version Updated app info component to honor the env app version if available
Summary of ChangesHello @ymaheshwari1, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces improvements for managing different application versions, particularly in environments where multiple versions might coexist or be deployed sequentially. It ensures that service workers from previous or inactive application versions are automatically unregistered, preventing potential conflicts or stale caching issues. Additionally, it refines how the application version is displayed within the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request introduces support for managing multiple app versions by unregistering old service workers and updating how the app version string is constructed. The changes are a good step forward. I've provided a couple of suggestions to improve code readability in DxpAppVersionInfo.vue and to enhance the robustness of the service worker cleanup logic in service-worker.ts by adding necessary checks and error handling.
Unregister all the service workers othen than the current app version Updated app info component to honor the env app version if available
Related Issues
Short Description and Why It's Useful
Screenshots of Visual Changes before/after (If There Are Any)
Is the changes contains any breaking change?
If there are any breaking change include those in the release notes file
Contribution and Currently Important Rules Acceptance