Improved: image component to use the oms url as default resource url

[ymaheshwari1]

Related Issues

Short Description and Why It's Useful

Removed usage of VUE_APP_RESOURCE_URL env as its maintained anymore and instead using the oms url to fetch the image

Screenshots of Visual Changes before/after (If There Are Any)

Is the changes contains any breaking change?

If there are any breaking change include those in the release notes file

• Yes
• No

Contribution and Currently Important Rules Acceptance

• I read and followed contribution rules

[gemini-code-assist]

Summary of Changes

Hello @ymaheshwari1, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refactors the DxpImage component to modernize its image resource fetching mechanism. It eliminates the dependency on the outdated VUE_APP_RESOURCE_URL environment variable. Instead, image resource URLs are now dynamically constructed based on the OMS URL, enhancing the component's robustness and reducing reliance on static, potentially unmaintained, environment configurations.

Highlights

• Environment Variable Removal: The VUE_APP_RESOURCE_URL environment variable, which is no longer maintained, has been removed from the DxpImage component.
• Dynamic Resource URL Generation: The image resource URL is now dynamically determined using the OMS URL obtained from useAuthStore().getOms.
• OMS URL Formatting: Logic has been added to correctly format the OMS URL, ensuring it starts with http and removing /api if present, or constructing a default https URL if needed.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request updates the image component to derive the resource URL from the OMS URL instead of a deprecated environment variable. The change is conceptually correct, but the implementation introduces a critical bug where the wrong image URL is being validated, preventing images from loading. There is also a bug in how the resource URL is constructed, which can lead to invalid image paths. Additionally, there's a minor performance issue related to Pinia store usage. I've provided comments with details on how to fix these issues.