Add push commands to open or hide full screen camera view#4688
Merged
Conversation
This was referenced Jun 2, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds two new push notification commands (show_camera / hide_camera) that allow the iOS app to present (or dismiss) a full-screen camera player overlay in response to notification commands, extending the existing notification-command pipeline used across APNs and local push.
Changes:
- Extend legacy push payload parsing to support
show_camera/hide_cameraand includeentity_idforshow_camera. - Add new notification command handlers and register them in
NotificationCommandManager. - Add app-side handling to present/dismiss a full-screen
CameraPlayerView, plus JSON fixtures for push-server contract tests.
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 8 comments.
Show a summary per file
| File | Description |
|---|---|
| Sources/SharedPush/Sources/NotificationParserLegacy.swift | Adds legacy parsing support for show_camera / hide_camera commands. |
| Sources/Shared/Notifications/NotificationCommands/NotificationsCommandManager.swift | Registers new camera command handlers. |
| Sources/Shared/Notifications/NotificationCommands/HandlerShowCamera.swift | Implements show_camera command handling by broadcasting an app event. |
| Sources/Shared/Notifications/NotificationCommands/HandlerHideCamera.swift | Implements hide_camera command handling by broadcasting an app event. |
| Sources/PushServer/Tests/SharedPushTests/notification_test_cases.bundle/command_show_camera.json | Adds push-server contract fixture for show_camera. |
| Sources/PushServer/Tests/SharedPushTests/notification_test_cases.bundle/command_hide_camera.json | Adds push-server contract fixture for hide_camera. |
| Sources/PushServer/SharedPush/Sources/NotificationParserLegacy.swift | Mirrors legacy parsing updates for the PushServer target. |
| Sources/App/Notifications/NotificationManager.swift | Presents/dismisses full-screen camera overlay and schedules a fallback local notification. |
| HomeAssistant.xcodeproj/project.pbxproj | Adds new handler source files to the Xcode project build. |
…ntain permissions' Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #4688 +/- ##
=======================================
Coverage ? 43.80%
=======================================
Files ? 282
Lines ? 17058
Branches ? 0
=======================================
Hits ? 7473
Misses ? 9585
Partials ? 0 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds push notification commands to open camera in full screen as well as closing it.
Screenshots
Link to pull request in Documentation repository
Documentation: home-assistant/companion.home-assistant#1338
FCM: home-assistant/mobile-apps-fcm-push#308
Any other notes