Skip to content

Rename live activity tags #4670

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bgoncal merged 4 commits into from
May 27, 2026
Merged

Rename live activity tags #4670

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7cfa0e3
Rename live activity tags
bgoncal May 27, 2026
c918e55
Update HAAPI.swift
bgoncal May 27, 2026
7692a93
Apply suggestion from @bgoncal
bgoncal May 27, 2026
0182369
Merge branch 'main' into live-activity-tweaks
bgoncal May 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Sources/Shared/API/HAAPI.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -612,7 +612,7 @@ public class HomeAssistantAPI {
// Push-to-start token (stored in Keychain at launch, updated via stream).
// The relay server uses this token to start a Live Activity entirely via APNs.
if let pushToStartToken = LiveActivityRegistry.storedPushToStartToken {
Comment on lines 613 to 614
appData["live_activity_push_to_start_token"] = pushToStartToken
appData["live_activity_token"] = pushToStartToken
appData["live_activity_push_to_start_apns_environment"] = Current.apnsEnvironment
}
}
Expand Down
6 changes: 3 additions & 3 deletions Sources/Shared/LiveActivity/LiveActivityRegistry.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ public actor LiveActivityRegistry: LiveActivityRegistryProtocol {
/// Webhook type for reporting that a Live Activity was dismissed.
static let webhookTypeDismissed = "mobile_app_live_activity_dismissed"
/// Keys in the dismissed webhook request data dictionary.
static let dismissedWebhookKeys: Set<String> = ["activity_id", "live_activity_tag", "reason"]
static let dismissedWebhookKeys: Set<String> = ["activity_id", "tag", "reason"]

// MARK: - State

Expand Down Expand Up @@ -265,7 +265,7 @@ public actor LiveActivityRegistry: LiveActivityRegistryProtocol {
AppConstants.Keychain[pushToStartTokenKeychainKey]
}

static let pushToStartTokenKeychainKey = "live_activity_push_to_start_token"
static let pushToStartTokenKeychainKey = "live_activity_token"

// MARK: - Private — Stale Date

Expand Down Expand Up @@ -354,7 +354,7 @@ public actor LiveActivityRegistry: LiveActivityRegistryProtocol {
type: Self.webhookTypeDismissed,
data: [
"activity_id": activityID,
"live_activity_tag": tag,
"tag": tag,
"reason": reason,
]
)
Expand Down