feat: compact default model route labels#2369
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Review: APPROVED ✅SummaryClean presentation-only change: adds compact display for Findings
Non-blocking note
Waiting for CI to complete before merge. |
There was a problem hiding this comment.
Review: APPROVE
Clean, well-bounded presentation-only change. The compact display projection for ModelRouteRef is consistently enforced across all Rust and Web GUI display surfaces, canonical values are preserved for serialization/persistence/API/test identity, and test coverage is thorough.
Minor nit
web-gui/app/src/features/dashboard/DashboardPage.tsx:127 — The <div title> tooltip also uses the compact form. Tooltips are a natural surface for exposing the full canonical route to power users. Consider using title={agent.model} to retain the canonical value there while keeping the visible <dd> compact. This is optional — the current behavior is internally consistent.
Assessment
- Correctness: No issues.
as_compact_display()correctly delegates tomodel_ref().as_string()for default endpoints. The TypeScriptcompactModelRouteDisplayhandles malformed inputs defensively. - Boundary discipline: All serialization, persistence, API values, comparison keys, and test assertions continue to use canonical
.as_string(). - Test coverage: Strong on both Rust and TypeScript sides — covers default, non-default, and malformed inputs, plus canonical identity preservation.
- Documentation: RFC update clearly states the compact form is presentation-only.
- Scope: Focused — no unrelated changes.
Holon Run Report
|
Summary
ModelRouteRefthat rendersprovider@default/modelasprovider/modelVerification
cargo test compactcargo test model_status_distinguishes_inherited_override_and_fallbackcargo fmt --all -- --checkRUSTFLAGS="-D warnings" cargo check --all-targetsnpm test(web-gui/app: 225 passed)npm run typecheck(web-gui/app)