Skip to content

Update dependencies#1

Open
filipbartek wants to merge 18 commits into
masterfrom
update-dependencies
Open

Update dependencies#1
filipbartek wants to merge 18 commits into
masterfrom
update-dependencies

Conversation

@filipbartek

@filipbartek filipbartek commented Sep 4, 2019

Copy link
Copy Markdown
Member

Summary of changes

  • Raise JDK version from 7u80 to 11.0.4 (README.md). Make the build compatible with JDK 11. The output binary remains compatible with JRE 7.
  • Update dependencies and plugins:
    • Update Maven dependencies (references to libraries PDFMU functionality depends on). (pom.xml: build.dependencies)
    • Update some Maven plugins (references to plugins the build depends on). (pom.xml: build.plugins)
    • Document how to update dependencies and plugins in src/site/fml/development.fml.
  • Ignore two tests:
    • MainBasicTest.testLegalNotice: I don't know why this test is failing. My best guess is that it is due to JDK upgrade. I propose to ignore this test because it has little importance – it only checks the text of the legal notice.
    • MainSignTsaIT.testCertificateSuccess: I think that the test is failing because it depends on a third-party test TSA and this TSA has an obsolete certificate. I estimate that it would be difficult to fix this test.
  • Raise NetBeans version from 8.1 in 11.0 (README.md).
  • Raise output PDFMU version from 1.1.3 to 1.1.4 (pom.xml: build.version).

Tasks

  • Ensure that all the Maven goals work:
    • javadoc:javadoc
    • verify
    • site
  • Document how to update dependencies
  • Optional: Restore the ignored tests
    • MainBasicTest.testLegalNotice (unimportant)
    • MainSignTsaIT.testCertificateSuccess (difficult to fix)
  • Optional: Update remaining Maven plugins
  • Tag the commit "1.1.4" after merging into master
  • Publish updated site
  • Publish binaries

Resolve a test failure.
The test that is failing after upgrading JDK to 11.0.4:
MainBasicTest.testLegalNotice
Version 2.6.2 was reported by GitHub as vulnerable.
Update the dependencies using the command `mvn versions:use-latest-releases`.
See https://stackoverflow.com/a/974787/4054250

Update all the dependencies that can be updated without breaking the build or the tests.
@filipbartek filipbartek requested a review from theo1024 September 4, 2019 22:34
to allow parallel builds without warning.
To build in parallel, run e.g. `mvn -T 1C`.
This HTML tag is not supported by javadoc plugin.
because it relies on a remote TSA service that is no longer supported
and it would be too much work to fix the test.
Changes:

* Update dependencies to latest stable versions
@filipbartek filipbartek marked this pull request as ready for review September 12, 2019 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant