[erika-wallace]

Summary

This PR validates the resolvePgDatabase fix in @heroku/sdk against the regression michaelmalave found reviewing #3980: an invalid DATABASE argument to pg:backups:capture or pg:backups:schedule was mislabeled is not yet provisioned instead of Unknown database: <name>. Valid options are: <list>. The cause was in the SDK's resolver, not those commands — data.database.describe() resolves the attachment and fetches its info in one call, and the attachment-resolution 404 surfaced as the same NotFoundError type the commands already catch to build their "not yet provisioned" message. Since the regression lives in the resolver, the fix was scoped to a separate heroku-sdk PR rather than bundled into #3980.

No command code changes are needed in this PR — the fix is entirely in the SDK's resolver. V12-CHANGES.md is updated to describe the resulting message differences, since the fix reshapes resolver error messages for every command that resolves a Postgres database through the SDK (not just the two from #3980).

Type of Change

Breaking Changes (major semver update)

• Add a ! after your change type to denote a change that breaks current behavior

Feature Additions (minor semver update)

• feat: Introduces a new feature to the codebase

Patch Updates (patch semver update)

• fix: Bug fix
• deps: Dependency upgrade
• revert: Revert a previous commit
• chore: Change that does not affect production code
• refactor: Refactoring existing code without changing behavior
• test: Add/update/remove tests

Testing

Notes:

Requires an app with a Heroku Postgres database attached.

Setup:

1. Pull down this branch
2. npm i && npm run build
3. heroku logout && HEROKU_NETRC_WRITE=true ./bin/run login

Steps

1. Create a backup using an invalid database. Confirm the error is Unknown database: FAKE_DATABASE on <app>. Valid options are: <list>

./bin/run pg:backups:capture FAKE_DATABASE --app <app>

2. Create a backup on an app with no databases. Confirm the error is <app> has no <service> databases

./bin/run pg:backups:capture --app <app>

3. Schedule a backup using an invalid database. Confirm the error is Unknown database: FAKE_DATABASE on <app>. Valid options are: <list>

./bin/run pg:backups:schedule FAKE_DATABASE --app <app> --at 03:00

4. Schedule a backup on an app with no databases. Confirm the error is <app> has no <service> databases

./bin/run pg:backups:schedule --app <app> --at 03:00

Cleanup

• ./bin/run logout

Screenshots (if applicable)

Related Issues

GUS work item: W-24493221

[tlowrimore-heroku]

LGTM!