Repository navigation
test: assert command failures from the error runCommand returns - #3997
Merged
Merged
Conversation
jdodson
approved these changes
Oct 15, 2026
jdodson
left a comment
jdodson
left a comment
Contributor
There was a problem hiding this comment.
Thank you for doing this!
Approved!
eablack
added a commit
that referenced
this pull request
Oct 23, 2026
The merge from main reverted PR #3997's hardening in six unit tests, dropping back to the try/catch (and .catch(() => {})) form that passes vacuously when the command does not throw. Reapply the pattern to v12's SDK-based test structure: capture the error from the result (const {error} = await runCommand(...) / runWithCliArgv(...)) and assert on it directly instead of swallowing it. Files: addons/create, addons/upgrade, run/index, run/inside, spaces/index, telemetry/add.
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR ensures unit tests actually check command failures.
runCommandnever rejects. When a command throws, it resolves with{error, stderr, stdout}. Tests that wrappedrunCommandin.catch()ortry/catchnever entered thatcatch, so theexpectcalls inside it never ran and the tests still passed. Those tests now readerroroff the resolved result, so a missing or unexpected error fails the test.A few expected messages were also wrong and only showed up once the assertions ran: the accounts alias and current-account copy, and
apps:leave, whose delete mock returned success. That delete now returns an error.Type of Change
Breaking Changes (major semver update)
!after your change type to denote a change that breaks current behaviorFeature Additions (minor semver update)
Patch Updates (patch semver update)
Testing
Notes:
Steps:
Screenshots (if applicable)
Related Issues
GUS work item: W-24510107