Growlibm diff

Makefile

@@ -1,4 +1,13 @@
-.PHONY: help install egg-herbie nightly index start-server deploy coverage
+UNAME_S := $(shell uname -s)
+LIB_EXT := so
+LIB_FLAGS := -shared -fPIC
+
+ifeq ($(UNAME_S), Darwin)
+    LIB_EXT := dylib
+    LIB_FLAGS := -dynamiclib
+endif
+
+.PHONY: help install egg-herbie nightly index start-server deploy coverage compile-accelerators time-ops evaluate-proj evaluate-basilisk evaluate-coolprop evaluate generate
 
 help:
 	@echo "Type 'make install' to install Herbie"
@@ -46,7 +55,51 @@ minimal-distribution:
 	[ ! -f herbie ] || (raco distribute herbie-compiled herbie && rm herbie)
 
 nightly:
-	bash infra/nightly.sh bench reports --threads 2
+	make generate
+
+generate:
+	bash growlibm/generate.sh
+
+time-ops:
+	mkdir -p growlibm/timing/drivers
+	make compile-accelerators
+	python3 growlibm/timing/time_ops.py
+
+evaluate:
+	make evaluate-proj
+	make evaluate-basilisk
+	make evaluate-coolprop
+
+evaluate-proj:
+	bash growlibm/evaluate.sh bench/proj/ reports proj 
+
+evaluate-basilisk:
+	bash growlibm/evaluate.sh bench/orbital-motion.fpcore reports basilisk 
+
+evaluate-coolprop:
+	bash growlibm/evaluate.sh bench/helmholtz.fpcore reports coolprop 
+
+compile-accelerators:
+	clang $(LIB_FLAGS) -O3 -o growlibm/accelerators/libaccelerators.$(LIB_EXT) \
+		growlibm/accelerators/accelerators.c \
+		growlibm/accelerators/cosquot.c \
+		growlibm/accelerators/e_rem_pio2.c \
+		growlibm/accelerators/powcos.c \
+		growlibm/accelerators/invgud.c \
+		-lm
+
+generate-table:
+	make compile-accelerators
+	racket growlibm/eval/generate-table.rkt
+	pandoc growlibm/eval/accelerator-table.tex -o out.html
+
+make-graphs:
+	python3 growlibm/eval/evaluate-frontier.py reports/proj PROJ --accelerators-only --max-relative-speedup 1.5
+	python3 growlibm/eval/evaluate-frontier.py reports/basilisk Basilisk --accelerators-only --max-relative-speedup 2.5
+	python3 growlibm/eval/evaluate-frontier.py reports/coolprop CoolProp --accelerators-only --max-relative-speedup 2
+	python3 growlibm/eval/evaluate-best-alt-bars.py reports/proj PROJ
+	python3 growlibm/eval/evaluate-best-alt-bars.py reports/basilisk Basilisk
+	python3 growlibm/eval/evaluate-best-alt-bars.py reports/coolprop CoolProp 
 
 upgrade:
 	git pull

README.md

@@ -1,4 +1,14 @@
-![Herbie](logo.png)
+# GROWLIBM
+
+## Install and Running Growlibm
+Run `make generate` to install and run growlibm on the PBRT library
+
+## Dependencies
+Racket v8.17
+rustc 1.91.0
+Python 3.14.0
+
+<!-- ![Herbie](logo.png)
 
 
 Herbie automatically improves the error of floating point expressions.
@@ -58,4 +68,4 @@ you can see more examples in `bench/`.
 
 Besides `shell`, Herbie has batch the `improve` and `report` commands.
 The [documentation](https://herbie.uwplse.org/doc/latest/options.html)
-has more details.
+has more details. -->

growlibm/.gitignore

@@ -0,0 +1,8 @@
+timing/
+chassis_tuning/
+benchmark
+drivers/
+
+libaccelerators.dylib
+eval/accelerator-table.tex
+accelerators/libaccelerators.dylib

growlibm/BenchmarkInstructions.md

@@ -0,0 +1,32 @@
+You are tasked with generating new benchmarks for Herbie, a numerical compiler that rewrites floating-point expressions to reduce error. 
+
+When you receive a new source file:
+
+1. **Skim for numerically fragile code paths.** Focus on
+   - Branches guarding against domain violations (division by zero, `fabs` comparisons, overflow checks).
+   - Expressions wrapped in conditionals, iterative refinements, or polynomial corrections applied only to small ranges.
+   - Sequences of transcendental functions (`exp`, `asinh`, `atan2`, etc.) composed together.
+
+2. **Score candidate expressions.** Prefer ones that are
+   - Prone to catastrophic cancellation (differences of comparably sized terms, exponentials combined with reciprocals).
+   - Already noted as “exact”, “correction”, or “series expansion” code by the source comments.
+
+3. **Isolate the expression.** For each expression:
+   - Identify the minimal set of variables needed (pull intermediate definitions when helpful).
+   - Convert to FPCore using lisp syntax.
+   - Add a `:pre` condition mirroring parameter invarients. Don't worry about adding `:pre` conditions for mathematical domain checks as Herbie's sampler already takes care of this. 
+   - Name the fpcores something reasonable but don't prefix the name with the name of the benchmark file.
+   - Use `let*` and `let` as needed. Make sure to wrap variable assignment in square brackets in `let` expressions.
+   - Ensure that `+` and `*` are only used as binary operations.
+   - Preserve structure instead of using algebraic simplifications.
+
+4. **Validate syntax.** Run
+
+   ```
+   racket -y src/main.rkt report --platform vanilla <FPCORE FILE> out
+   ```
+
+   Fix any syntax errors Herbie reports (missing parentheses, unsupported identifiers, missing preconditions). Rerun until the file parses cleanly. Warnings about improvement quality are fine; only syntax errors must be resolved. Make sure that the number of FPCores you
+   add to the file is the same number that appears in the report when you run this command.
+
+Aim for a set of 15–20 expressions that represent the numerical behaviors from the source file. Ideally, this collection will include hard expressions that Herbie has trouble improving. 

growlibm/accelerator-table.html

@@ -0,0 +1,36 @@
+<!DOCTYPE html>
+<html lang="en">
+<head>
+  <meta charset="UTF-8">
+  <title>growlibm Accelerators</title>
+</head>
+<body>
+  <h1>growlibm accelerators</h1>
+  <table border="1" cellspacing="0" cellpadding="6">
+    <thead>
+      <tr>
+        <th>name</th>
+        <th>origin</th>
+        <th>spec</th>
+        <th>cost</th>
+        <th>accuracy</th>
+        <th>cost of spec</th>
+        <th>accuracy of spec</th>
+      </tr>
+    </thead>
+    <tbody>
+<tr><td>cosprod</td><td></td><td><code>(cos (* x y))</code></td><td>12800</td><td>87.99%</td><td>6784</td><td>57.33%</td></tr>
+<tr><td>hypot</td><td></td><td><code>(sqrt (+ (* x x) (* y y)))</code></td><td>3200</td><td>99.99%</td><td>1536</td><td>54.45%</td></tr>
+<tr><td>invgud</td><td></td><td><code>(log (tan (* (+ (+ x x) (PI)) 1/4)))</code></td><td>25000</td><td>99.87%</td><td>13568</td><td>4.05%</td></tr>
+<tr><td>log1pmd</td><td></td><td><code>(log (/ (+ 1 x) (- 1 x)))</code></td><td>3200</td><td>100.00%</td><td>7552</td><td>8.86%</td></tr>
+<tr><td>pow1ms</td><td></td><td><code>(pow (* (- 1 x) (- 1 x)) y)</code></td><td>8320</td><td>99.97%</td><td>7232</td><td>73.80%</td></tr>
+<tr><td>powcos</td><td></td><td><code>(pow (cos x) y)</code></td><td>64000</td><td>100.00%</td><td>12928</td><td>93.19%</td></tr>
+<tr><td>powcos2</td><td></td><td><code>(pow (cos x) 2)</code></td><td>64000</td><td>99.70%</td><td>12928</td><td>99.72%</td></tr>
+<tr><td>powcos4</td><td></td><td><code>(pow (cos x) 4)</code></td><td>64000</td><td>99.42%</td><td>12928</td><td>99.38%</td></tr>
+<tr><td>powcos6</td><td></td><td><code>(pow (cos x) 6)</code></td><td>64000</td><td>99.08%</td><td>12928</td><td>99.03%</td></tr>
+<tr><td>sinprod</td><td>PROJ</td><td><code>(sin (* x y))</code></td><td>12800</td><td>89.11%</td><td>6784</td><td>58.58%</td></tr>
+<tr><td>verdcos</td><td></td><td><code>(- (cos (+ x x)) 1)</code></td><td>9600</td><td>99.58%</td><td>6848</td><td>76.48%</td></tr>
+    </tbody>
+  </table>
+</body>
+</html>

growlibm/accelerators.c

@@ -0,0 +1,68 @@
+//clang -dynamiclib -O3 -o libaccelerators.dylib accelerators.c
+#include <math.h>
+#include <stdio.h>
+
+double sin_xy(double x, double y) {
+    double p = x * y;
+    double q = fma(x, y, -p); 
+
+    double sin_p, cos_p, sin_q, cos_q;
+    __sincos(p, &sin_p, &cos_p);
+    __sincos(q, &sin_q, &cos_q);
+    return fma(sin_p, cos_q, cos_p * sin_q);
+}
+
+double cos_xy(double x, double y) {
+    double p = x * y;
+    double q = fma(x, y, -p); 
+
+    double sin_p, cos_p, sin_q, cos_q;
+    __sincos(p, &sin_p, &cos_p);
+    __sincos(q, &sin_q, &cos_q);
+
+    return fma(cos_p, cos_q, -sin_p * sin_q);
+}
+
+double sin_quotient_xy(double x, double y) {
+    double p = x / y;            
+    double r = fma(-p, y, x);    
+    double q = r / y;             
+
+    double sin_p, cos_p, sin_q, cos_q;
+    __sincos(p, &sin_p, &cos_p); 
+    __sincos(q, &sin_q, &cos_q); 
+
+    return fma(sin_p, cos_q, cos_p * sin_q);
+}
+
+double cos_quotient_xy(double x, double y) {
+    double p = x / y;
+    double r = fma(-p, y, x);
+    double q = r / y;
+
+    double sin_p, cos_p, sin_q, cos_q;
+    __sincos(p, &sin_p, &cos_p);
+    __sincos(q, &sin_q, &cos_q);
+
+    return fma(cos_p, cos_q, -sin_p * sin_q);
+}
+
+// double approx_sin_xy(double x, double y) {
+//     double p = x * y;
+//     double q = fma(x, y, -p); 
+
+//     double sin_p, cos_p;
+//     __sincos(p, &sin_p, &cos_p);
+
+//     return fma(sin_p, 1, cos_p);
+// }
+
+// double approx_cos_xy(double x, double y) {
+//     double p = x * y;
+//     double q = fma(x, y, -p); 
+
+//     double sin_p, cos_p;
+//     __sincos(p, &sin_p, &cos_p);
+
+//     return fma(cos_p, 1, -sin_p);
+// }