Refactor/74 buildtime rubric parsing#84
Merged
Merged
Conversation
alxsuv
commented
May 28, 2026
alxsuv
commented
Member
- Move Rubric parsing from runtime to build time (DSL, deserializer). Node.getRubric() now returns typed Rubric instead of raw String. RubricEngine.evaluate() takes Rubric directly — no repository lookup, no _rubric_id context-key round-trip.
- Keep RubricRepository as placeholder for future DB-backed store. Delete 58 trivial/tautological tests (record properties, HashMap wrappers).
…ntext key - Move Rubric parsing from runtime to build time (DSL, deserializer). Node.getRubric() now returns typed Rubric instead of raw String. RubricEngine.evaluate() takes Rubric directly — no repository lookup, no _rubric_id context-key round-trip. - Keep RubricRepository as placeholder for future DB-backed store. Delete 58 trivial/tautological tests (record properties, HashMap wrappers). Resolve: #74 Signed-off-by: Aleksandr Suvorov <asuvorov@hensu.io>
Resolve: #74 Signed-off-by: Aleksandr Suvorov <asuvorov@hensu.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.