Small refactor from #938#2360
Open
brownbaerchen wants to merge 5 commits into
Open
Conversation
mtar
requested changes
Jun 17, 2026
mtar
left a comment
mtar
left a comment
Collaborator
There was a problem hiding this comment.
We don't have a consistent style for the type notation in the docstrings. My suggestions are from one style that we have throughout the library, but we can discuss which one we want to use.
Comment on lines
+80
to
+83
| self.__balanced: bool = balanced | ||
| self.__ishalo = False | ||
| self.__halo_next = None | ||
| self.__halo_prev = None | ||
| self.__halo_next: torch.Tensor | None = None | ||
| self.__halo_prev: torch.Tensor | None = None |
Collaborator
There was a problem hiding this comment.
Is there a reason why exactly these fields have a type hint?
Collaborator
Author
There was a problem hiding this comment.
I just copied this from #938, I guess because this doesn't have a non None default value..?
| # fit the clusters | ||
| k = 3 | ||
| kmedian = ht.cluster.KMedians(n_clusters=k) | ||
| kmedian = ht.cluster.KMedians(n_clusters=k, random_state=1) |
Collaborator
There was a problem hiding this comment.
Why do you pass an argument for random_state?
Collaborator
Author
There was a problem hiding this comment.
This is a random change from #938. I can remove it from here and there, if you want..
Co-authored-by: Michael Tarnawa <18899420+mtar@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These are a few changes from #938 that are not related to advanced indexing, but are simply small refactorings. They shouldn't change the behavior meaningfully.