Expand indexing tests#2257
Closed
brownbaerchen wants to merge 7 commits into
Closed
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR merges a subset of the distributed indexing test coverage from #938 into main, intended to reduce the size/risk of the later advanced indexing implementation diff while keeping only tests that already pass on current main.
Changes:
- Add a comprehensive
__getitem__test covering scalar indexing, slicing/striding, ellipsis/newaxis handling, and selected advanced indexing cases (local + distributed). - Add a
__setitem__test covering scalar assignment and dimensional indexing (ellipsis/newaxis), including distributed scenarios.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Collaborator
Author
|
Not sure why the codebase CI isn't triggered, but here is the GitHub CI that ran on my fork. We really need to figure out a way to run the CI here on PRs from forks as well. |
ClaudiaComito
changed the title
ClaudiaComito
added
testing
Collaborator
Author
|
Wait for #2259 to be merged in order to trigger CI on codebase in this PR. |
ClaudiaComito
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The advanced indexing that is developed in #938 needs to be merged! This is a preparatory PR that reduces the diff in that PR by merging some of tests that pass on the current main. This will hopefully speed up the review process a tiny bit.