matcher: Implement prefer_basename mode#101
Open
archseer wants to merge 1 commit into
Open
Conversation
pascalkuthe
reviewed
Jun 24, 2026
| let score = self.fuzzy_matcher_impl_raw::<INDICES>(haystack_, needle_, indices)?; | ||
| // Reward a match that also lands in the basename so a file whose name | ||
| // matches outranks siblings that only match a shared parent directory. | ||
| // The bonus is the matcher's own score for the needle against that |
Member
There was a problem hiding this comment.
Thats a pretty high bonus...
Mahbe thats ok but it seems quite high. Is that also waht fzf does?
Member
Author
There was a problem hiding this comment.
Fair, fzf only uses this to resolve tiebreaks (it sets --tiebreak=pathname,length). I think the better solution is to add BONUS_BOUNDARY to the score. Enough to resolve the tie break, but not enough to prefer the basename match in the cases where there's better scoring matches available.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Match fzf's
--scheme=path: matches in the basename boost the candidate score. I've been bothered by this for a while on larger repositories. Slight performance hit for searching paths if enabled, but it only runs scoring for candidates that match in the first place.Fixes #93