Addressed copilot review#1282
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refines HED query parsing and reporting, primarily by clarifying how the @tag prefix is handled and by improving readability of query-parse error details returned to callers.
Changes:
- Treat
@tagas a prefix handled byExpression.__init__rather than a standalone token kind inToken. - Normalize exception whitespace in
get_query_handlersso parse errors are returned as single-line, more readable issue strings.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
hed/models/query_util.py |
Removes @ from the token mapping and updates the NotInLine comment to reflect prefix handling. |
hed/models/query_service.py |
Collapses whitespace in exception details when building [BadQuery ...] issue messages. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.