Updated the schema compliance to check only the latest versions#1233
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates schema compliance behavior to focus on latest-version checks and re-enables schema test execution.
Changes:
- Re-enabled running
schema_testsinspec_tests/test_errors.py. - Adjusted deprecation validation to avoid treating inherited
deprecatedFromas explicitly present on child tags. - Updated inheritable-attribute selection to exclude
InLibrary, and bumped thespec_tests/hed-testssubmodule.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| spec_tests/test_errors.py | Re-enables schema test execution in the test runner. |
| spec_tests/hed-tests | Updates the pinned submodule revision used by spec tests. |
| spec_tests/_debug_dep_tests.py | Adds a local debugging script to investigate deprecation test failures. |
| hed/schema/schema_attribute_validators.py | Changes child-tag deprecated checks to look at explicit attributes only. |
| hed/schema/hed_schema_section.py | Excludes InLibrary from inheritable attributes for schema 8.3 props. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.