Started setting up of hed-schemas validation#1229
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request introduces infrastructure for validating HED schemas by adding a comprehensive schema loading test script and renaming an existing BIDS validation test file. The PR establishes a framework to systematically test schema loading across all formats (XML, MediaWiki, JSON, TSV) from the hed-schemas submodule.
Changes:
- Added
try_loading_all_schemas.py- a standalone script to test loading of schemas from the hed-schemas submodule with support for filtering by format, library, and release status - Renamed validation test from
validate_bids.pytotest_bids_datasets.pyfor consistency with naming conventions - Updated documentation and workflow references to reflect the renamed test file
Reviewed changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| spec_tests/try_loading_all_schemas.py | New comprehensive schema loading test script with CLI for testing schemas across formats, libraries, and release versions |
| spec_tests/test_bids_datasets.py | New BIDS dataset validation test file (renamed from validate_bids.py) with graceful handling of missing submodules |
| spec_tests/check_setup.py | Updated reference from validate_bids.py to test_bids_datasets.py |
| spec_tests/README.md | Added extensive documentation for try_loading_all_schemas.py script usage and updated file references |
| .github/workflows/spec_tests.yaml | Updated workflow to use renamed test_bids_datasets.py file |
Comments suppressed due to low confidence (1)
spec_tests/check_setup.py:93
- The manual setup instructions should include the hed-schemas repository, similar to the README.md. Add "3. Clone hed-schemas repository to spec_tests/hed-schemas/" to match the complete list of submodules defined in .gitmodules.
print("\nAlternatively, manually clone:")
print("1. Clone hed-tests repository to spec_tests/hed-tests/")
print("2. Clone hed-examples repository to spec_tests/hed-examples/")
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.