Skip to content

Started setting up of hed-schemas validation#1229

Merged
VisLab merged 2 commits into
hed-standard:mainfrom
VisLab:fix_extras
Feb 23, 2026
Merged

Started setting up of hed-schemas validation#1229
VisLab merged 2 commits into
hed-standard:mainfrom
VisLab:fix_extras

Conversation

@VisLab

@VisLab VisLab commented Feb 23, 2026

Copy link
Copy Markdown
Member

No description provided.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request introduces infrastructure for validating HED schemas by adding a comprehensive schema loading test script and renaming an existing BIDS validation test file. The PR establishes a framework to systematically test schema loading across all formats (XML, MediaWiki, JSON, TSV) from the hed-schemas submodule.

Changes:

  • Added try_loading_all_schemas.py - a standalone script to test loading of schemas from the hed-schemas submodule with support for filtering by format, library, and release status
  • Renamed validation test from validate_bids.py to test_bids_datasets.py for consistency with naming conventions
  • Updated documentation and workflow references to reflect the renamed test file

Reviewed changes

Copilot reviewed 4 out of 5 changed files in this pull request and generated 6 comments.

Show a summary per file
File Description
spec_tests/try_loading_all_schemas.py New comprehensive schema loading test script with CLI for testing schemas across formats, libraries, and release versions
spec_tests/test_bids_datasets.py New BIDS dataset validation test file (renamed from validate_bids.py) with graceful handling of missing submodules
spec_tests/check_setup.py Updated reference from validate_bids.py to test_bids_datasets.py
spec_tests/README.md Added extensive documentation for try_loading_all_schemas.py script usage and updated file references
.github/workflows/spec_tests.yaml Updated workflow to use renamed test_bids_datasets.py file
Comments suppressed due to low confidence (1)

spec_tests/check_setup.py:93

  • The manual setup instructions should include the hed-schemas repository, similar to the README.md. Add "3. Clone hed-schemas repository to spec_tests/hed-schemas/" to match the complete list of submodules defined in .gitmodules.
        print("\nAlternatively, manually clone:")
        print("1. Clone hed-tests repository to spec_tests/hed-tests/")
        print("2. Clone hed-examples repository to spec_tests/hed-examples/")

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread spec_tests/try_loading_all_schemas.py Outdated
Comment thread spec_tests/README.md
Comment thread spec_tests/README.md Outdated
Comment thread spec_tests/README.md
Comment thread spec_tests/try_loading_all_schemas.py
Comment thread spec_tests/try_loading_all_schemas.py Outdated
@VisLab VisLab merged commit e2aacd0 into hed-standard:main Feb 23, 2026
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants