Reorganized the submodules so tests aren't skipped.#1227
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR reorganizes git submodules for test data to ensure tests are no longer skipped. The changes add submodule definitions, update test paths to match the new data structure, and add comprehensive TSV roundtrip testing.
Changes:
- Added git submodule configurations for hed-tests, hed-schemas, and hed-examples
- Updated test data directory paths from "schema_tests" and "validation_tests" to "schema_test_data" and "validation_test_data"
- Enhanced schema roundtrip tests to include TSV format testing and fixed path generation logic
Reviewed changes
Copilot reviewed 8 out of 9 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| .gitmodules | Added hed-schemas submodule definition and fixed hed-examples URL |
| .gitignore | Removed hed-examples and hed-tests from gitignore to allow submodule tracking |
| CONTRIBUTING.md | Added documentation for initializing git submodules |
| spec_tests/hed-tests | Added submodule commit reference |
| spec_tests/hed-schemas | Added submodule commit reference |
| spec_tests/hed-examples | Added submodule commit reference |
| spec_tests/test_errors.py | Updated test data directory paths to match new structure |
| tests/schema/test_schema_format_roundtrip.py | Added TSV roundtrip testing and improved path generation for edge case schemas |
| tests/data/schema_tests/HED_testunpart_1.0.0.mediawiki | Added new test schema file for mediawiki format testing |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.