Added handling of in_library for extra sections in tsv format#1224
Added handling of in_library for extra sections in tsv format#1224VisLab wants to merge 5 commits into
Conversation
There was a problem hiding this comment.
Pull request overview
Adds TSV-specific handling for in_library provenance in schema “extras” sections (Sources, Prefixes, AnnotationPropertyExternal), aiming to ensure correct merging/filtering behavior for withStandard library schemas.
Changes:
- Add
in_librarycolumn to extras DataFrames when loading TSV library schemas. - Filter extras on unmerged TSV saves to output only library entries, and drop
in_libraryfrom TSV output. - Add a new TSV extras roundtrip test suite covering read/write and merged/unmerged scenarios.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
hed/schema/schema_io/df2schema.py |
Adds in_library augmentation for extras during TSV load. |
hed/schema/schema_io/schema2df.py |
Filters extras for unmerged saves and strips in_library from TSV output. |
tests/schema/test_schema_extras_tsv_roundtrip.py |
New tests for TSV extras roundtrip and serialization expectations. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 12 out of 12 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Decided on a different approach for saving unmerged extras. This PR is replaced by #1225 |
|
Replaced by #1225 (Different approach) |
No description provided.