Added roundtrip extras for mediawiki schema format#1222
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request adds support for roundtripping schema extras (Sources, Prefixes, and External Annotations) in MediaWiki format with proper in_library tracking. The changes enable library schemas to maintain proper attribution of extras sections when reading from and writing to MediaWiki format, supporting both merged and unmerged schema saves.
Changes:
- Added comprehensive test suite for MediaWiki extras roundtripping with in_library tracking
- Modified wiki2schema.py to parse and track inLibrary attributes from MediaWiki files and merge extras from withStandard base schemas
- Modified schema2wiki.py to filter and output extras based on save mode (merged vs unmerged) with proper inLibrary attribute handling
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| tests/schema/test_schema_extras_wiki_roundtrip.py | New test file validating extras I/O, merging, filtering, and roundtrip preservation for MediaWiki format |
| hed/schema/schema_io/wiki2schema.py | Added inLibrary attribute parsing, in_library column tracking, and extras merging logic for withStandard schemas |
| hed/schema/schema_io/schema2wiki.py | Added filtering for unmerged saves and inLibrary attribute output for merged saves |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.