Redesign entity view: 3-row list with Garmin-like UI#94
Open
leubeem wants to merge 1 commit into
Open
Conversation
Replace the single-entity full-screen view with a scrollable 3-visible-row list. Selected entity sits in the centre row with a dark navy background and a state-coloured angled accent bar (parallelogram slash shape). Adjacent rows are dimmed for depth. Row spacing uses internal vPad so the layout stays lightweight and breathes on all screen sizes. Touch support: onTap toggles the selected entity, onSwipe navigates the list, onHold opens the settings menu — covering both touch-only and button-only Garmin devices. Icon bitmaps are now cached per visible row (max 3 in memory at once) and evicted when scrolled out of view. This removes a loadResource() call per frame that was hitting the filesystem on every onUpdate(). Accent bar colour encodes entity state at a glance: green = on / open / unlocked orange = transitional (locking, opening, closing) blue = read-only sensor purple = one-shot trigger (scene / script / button) gray = off / closed / locked Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Author
|
@hatl Have you had a chance to look over my PR yet? :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, did some Claude co-authored coding and changed the layout to a 3-row list, added a colored bar and made some other small changes.
Happy for feedback :)
What changed
The entity view was a single full-screen card (icon centred, name below).
This PR replaces it with a 3-row scrollable list, matching the visual
language of Garmin's native training and activity screens.
List layout
any hard separator lines
explicit gap arithmetic
Accent bar
fillPolygonso the angle is crisp on all display typesInput handling
onTap→ toggle selected entity (covers touch watches whereBehaviorDelegate does not always translate taps to onSelect)
onSwipe UP/DOWN→ navigate list (raw swipe events on touch-only devices)onHold→ settings menu (long press)Icon caching
loadResource()previously ran on everyonUpdate()— a filesystem readevery frame on every device
entity ID, validated against current (type, state, sensorClass)
regardless of list length