Skip to content

BE-467: Remove Default impl from QueryTemporalAxesUnresolved #8900

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TimDiekmann merged 2 commits into from
Jun 24, 2026
Merged

BE-467: Remove Default impl from QueryTemporalAxesUnresolved #8900

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8b2dca2
BE-467: Remove `Default` impl from `QueryTemporalAxesUnresolved`
TimDiekmann Jun 24, 2026
46c4519
BE-467: Inline temporal-axes test helpers onto canonical constructors
TimDiekmann Jun 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 2 additions & 8 deletions libs/@local/graph/postgres-store/src/store/postgres/knowledge/entity/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -685,10 +685,7 @@ where
entities
.iter()
.map(|entity| entity.metadata.entity_type_ids.clone()),
QueryTemporalAxesUnresolved::DecisionTime {
pinned: PinnedTemporalAxisUnresolved::new(None),
variable: VariableTemporalAxisUnresolved::new(None, None),
},
QueryTemporalAxesUnresolved::live_only(),
None,
)
.await?
Expand Down Expand Up @@ -1527,10 +1524,7 @@ where
.entities
.values()
.map(|entity| entity.metadata.entity_type_ids.clone()),
QueryTemporalAxesUnresolved::DecisionTime {
pinned: PinnedTemporalAxisUnresolved::new(None),
variable: VariableTemporalAxisUnresolved::new(None, None),
},
QueryTemporalAxesUnresolved::live_only(),
None,
)
.await?
Expand Down
21 changes: 4 additions & 17 deletions libs/@local/graph/postgres-store/src/store/postgres/ontology/data_type.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,10 +27,7 @@ use hash_graph_store::{
TraversalEdge,
},
identifier::{DataTypeVertexId, GraphElementVertexId},
temporal_axes::{
PinnedTemporalAxisUnresolved, QueryTemporalAxes, QueryTemporalAxesUnresolved,
VariableAxis, VariableTemporalAxisUnresolved,
},
temporal_axes::{QueryTemporalAxes, QueryTemporalAxesUnresolved, VariableAxis},
},
};
use hash_graph_temporal_versioning::{RightBoundedTemporalInterval, Timestamp, TransactionTime};
Expand Down Expand Up @@ -625,10 +622,7 @@ where
parameters: ParameterList::DataTypeIds(&required_reference_ids),
},
),
temporal_axes: QueryTemporalAxesUnresolved::DecisionTime {
pinned: PinnedTemporalAxisUnresolved::new(None),
variable: VariableTemporalAxisUnresolved::new(None, None),
},
temporal_axes: QueryTemporalAxesUnresolved::live_only(),
after: None,
limit: None,
include_count: false,
Expand Down Expand Up @@ -1055,10 +1049,7 @@ where
parameters: ParameterList::DataTypeIds(&required_parent_ids),
},
),
temporal_axes: QueryTemporalAxesUnresolved::DecisionTime {
pinned: PinnedTemporalAxisUnresolved::new(None),
variable: VariableTemporalAxisUnresolved::new(None, None),
},
temporal_axes: QueryTemporalAxesUnresolved::live_only(),
after: None,
limit: None,
include_count: false,
Expand Down Expand Up @@ -1599,11 +1590,7 @@ where
authenticated_actor: AuthenticatedActor,
params: HasPermissionForDataTypesParams<'_>,
) -> Result<HashSet<VersionedUrl>, Report<hash_graph_store::error::CheckPermissionError>> {
let temporal_axes = QueryTemporalAxesUnresolved::DecisionTime {
pinned: PinnedTemporalAxisUnresolved::new(None),
variable: VariableTemporalAxisUnresolved::new(None, None),
}
.resolve();
let temporal_axes = QueryTemporalAxesUnresolved::live_only().resolve();
let mut compiler = SelectCompiler::new(Some(&temporal_axes), true);

let data_type_uuids = params
Expand Down
23 changes: 5 additions & 18 deletions libs/@local/graph/postgres-store/src/store/postgres/ontology/entity_type.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,10 +32,7 @@ use hash_graph_store::{
SubgraphTraversalParams, TraversalEdge,
},
identifier::{EntityTypeVertexId, GraphElementVertexId, PropertyTypeVertexId},
temporal_axes::{
PinnedTemporalAxisUnresolved, QueryTemporalAxes, QueryTemporalAxesUnresolved,
VariableAxis, VariableTemporalAxisUnresolved,
},
temporal_axes::{QueryTemporalAxes, QueryTemporalAxesUnresolved, VariableAxis},
},
};
use hash_graph_temporal_versioning::{RightBoundedTemporalInterval, Timestamp, TransactionTime};
Expand Down Expand Up @@ -242,7 +239,7 @@ where
traversal_paths: Vec::new(),
request: QueryPropertyTypesParams {
filter: Filter::for_property_type_uuids(&property_type_uuids),
temporal_axes: QueryTemporalAxesUnresolved::default(),
temporal_axes: QueryTemporalAxesUnresolved::all(),
after: None,
limit: None,
include_count: false,
Expand Down Expand Up @@ -1005,10 +1002,7 @@ where
parameters: ParameterList::EntityTypeIds(&required_reference_ids),
},
),
temporal_axes: QueryTemporalAxesUnresolved::DecisionTime {
pinned: PinnedTemporalAxisUnresolved::new(None),
variable: VariableTemporalAxisUnresolved::new(None, None),
},
temporal_axes: QueryTemporalAxesUnresolved::live_only(),
after: None,
limit: None,
include_count: false,
Expand Down Expand Up @@ -1601,10 +1595,7 @@ where
parameters: ParameterList::EntityTypeIds(&required_reference_ids),
},
),
temporal_axes: QueryTemporalAxesUnresolved::DecisionTime {
pinned: PinnedTemporalAxisUnresolved::new(None),
variable: VariableTemporalAxisUnresolved::new(None, None),
},
temporal_axes: QueryTemporalAxesUnresolved::live_only(),
after: None,
limit: None,
include_count: false,
Expand Down Expand Up @@ -2051,11 +2042,7 @@ where
})
.collect()
} else {
let temporal_axes = QueryTemporalAxesUnresolved::DecisionTime {
pinned: PinnedTemporalAxisUnresolved::new(None),
variable: VariableTemporalAxisUnresolved::new(None, None),
}
.resolve();
let temporal_axes = QueryTemporalAxesUnresolved::live_only().resolve();
let mut compiler = SelectCompiler::new(Some(&temporal_axes), true);

let entity_type_uuids = params
Expand Down
11 changes: 2 additions & 9 deletions libs/@local/graph/postgres-store/src/store/postgres/ontology/property_type.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,10 +25,7 @@ use hash_graph_store::{
TraversalEdge,
},
identifier::{DataTypeVertexId, GraphElementVertexId, PropertyTypeVertexId},
temporal_axes::{
PinnedTemporalAxisUnresolved, QueryTemporalAxes, QueryTemporalAxesUnresolved,
VariableAxis, VariableTemporalAxisUnresolved,
},
temporal_axes::{QueryTemporalAxes, QueryTemporalAxesUnresolved, VariableAxis},
},
};
use hash_graph_temporal_versioning::{RightBoundedTemporalInterval, Timestamp, TransactionTime};
Expand Down Expand Up @@ -1152,11 +1149,7 @@ where
authenticated_actor: AuthenticatedActor,
params: HasPermissionForPropertyTypesParams<'_>,
) -> Result<HashSet<VersionedUrl>, Report<hash_graph_store::error::CheckPermissionError>> {
let temporal_axes = QueryTemporalAxesUnresolved::DecisionTime {
pinned: PinnedTemporalAxisUnresolved::new(None),
variable: VariableTemporalAxisUnresolved::new(None, None),
}
.resolve();
let temporal_axes = QueryTemporalAxesUnresolved::live_only().resolve();
let mut compiler = SelectCompiler::new(Some(&temporal_axes), true);

let property_type_uuids = params
Expand Down
2 changes: 1 addition & 1 deletion libs/@local/graph/postgres-store/src/store/postgres/query/expression/where_clause.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,7 +137,7 @@ mod tests {
#[test]
#[expect(clippy::too_many_lines)]
fn transpile_where_expression() {
let temporal_axes = QueryTemporalAxesUnresolved::default().resolve();
let temporal_axes = QueryTemporalAxesUnresolved::all().resolve();
let mut compiler = SelectCompiler::<DataTypeWithMetadata>::new(Some(&temporal_axes), false);
let mut where_clause = WhereExpression::default();
assert_eq!(where_clause.transpile_to_string(), "");
Expand Down
Loading
Loading