FE-1048: Petrinaut use ds toggle#8891
Conversation
PR SummaryMedium Risk Overview Call sites move from
Reviewed by Cursor Bugbot for commit c929c76. Bugbot is set up for automated code reviews on this repo. Configure here. |
There was a problem hiding this comment.
Alignment
The thumbs are not properly aligned with the "rail":
Green vs Dark Gray
I personally prefer green for enablement, but this is just my opinion.
Would be worth checking with designers.
If you did it already, go with the dark gray.
"Refraction"
Refraction was already removed, now we remove the transform while dragging.
I wonder how we'll put refraction back.
🌟 What is the purpose of this PR?
Replaces Toggle in Petrinaut with toggle from the DS
@kube, the new Toggle has a few new tones(colors): neutral + brand, with neutral being the default - I've switched over a couple of the toggles to be neutral as a result, in particular, where the toggle behaves more like a form element rather than a setting, or where the success (green) variation felt too heavy/distracting.
The one controversial change in tone is likely in the user-settings dialog, since there are so many toggles on that dialog, making them neutral felt less visually distracting than all success.
Let me know if you prefer me to change any of the tones, and any other feedback also appreciated.
Pre-Merge Checklist 🚀
🚢 Has this modified a publishable library?
This PR:
📜 Does this require a change to the docs?
The changes in this PR: