pyproject file update#4
Merged
Merged
Conversation
taru-garg-2000
suggested changes
Aug 26, 2025
| Repository = "https://github.com/hashicorp/python-tfe" | ||
| "Repository" = "https://github.com/hashicorp/python-tfe" | ||
| "Bug Tracker" = "https://github.com/hashicorp/python-tfe/issues" | ||
|
|
Contributor
There was a problem hiding this comment.
is this the correct place to add it ?
Collaborator
Author
There was a problem hiding this comment.
Yes. It is added under project.urls in other repos
mukulmohan177
suggested changes
Aug 26, 2025
|
|
||
| # Ruff configuration | ||
| [tool.ruff] | ||
| target-version = "py310" |
There was a problem hiding this comment.
Usually in the RUFF configuration, we should specify the python versions similar to classifiers. Thois will apply the correct linting rules.
| [tool.ruff] | ||
| target-version = "py310" | ||
| line-length = 88 | ||
| line-length = 80 |
There was a problem hiding this comment.
I think 88 is good because modern projects have line length of 88.
Collaborator
Author
There was a problem hiding this comment.
Made the changes
taru-garg-2000
approved these changes
Aug 27, 2025
taru-garg-2000
left a comment
Contributor
There was a problem hiding this comment.
Approved, ensure when raising a PR we keep the PR template, due to compliance requirements
mukulmohan177
approved these changes
Aug 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
updated pyproject.toml for the initial setup of the project