Skip to content

pyproject file update#4

Merged
aayushsingh2502 merged 4 commits into
mainfrom
aayush/pyprojectUpdate
Aug 28, 2025
Merged

pyproject file update#4
aayushsingh2502 merged 4 commits into
mainfrom
aayush/pyprojectUpdate

Conversation

@aayushsingh2502

Copy link
Copy Markdown
Collaborator

updated pyproject.toml for the initial setup of the project

@aayushsingh2502 aayushsingh2502 requested a review from a team as a code owner August 26, 2025 12:53
Comment thread pyproject.toml Outdated
Comment thread pyproject.toml Outdated
Comment thread pyproject.toml
Comment thread pyproject.toml
Repository = "https://github.com/hashicorp/python-tfe"
"Repository" = "https://github.com/hashicorp/python-tfe"
"Bug Tracker" = "https://github.com/hashicorp/python-tfe/issues"

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this the correct place to add it ?

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. It is added under project.urls in other repos

Comment thread pyproject.toml

# Ruff configuration
[tool.ruff]
target-version = "py310"

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Usually in the RUFF configuration, we should specify the python versions similar to classifiers. Thois will apply the correct linting rules.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Comment thread pyproject.toml Outdated
[tool.ruff]
target-version = "py310"
line-length = 88
line-length = 80

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think 88 is good because modern projects have line length of 88.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made the changes

@taru-garg-2000 taru-garg-2000 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, ensure when raising a PR we keep the PR template, due to compliance requirements

@aayushsingh2502 aayushsingh2502 merged commit bef043a into main Aug 28, 2025
11 checks passed
@aayushsingh2502 aayushsingh2502 deleted the aayush/pyprojectUpdate branch August 28, 2025 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants